Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage STG 81 #16765

Merged
merged 4 commits into from
Nov 17, 2021
Merged

Storage STG 81 #16765

merged 4 commits into from
Nov 17, 2021

Conversation

seanmcc-msft
Copy link
Member

No description provided.

@openapi-workflow-bot
Copy link

Hi, @seanmcc-msft Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Nov 15, 2021

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    The following errors/warnings exist before current PR submission:
    Rule Message
    ⚠️ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options. Property name: QueryType
    Location: Microsoft.BlobStorage/preview/2021-04-10/blob.json#L10796
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️⚠️Cross-Version Breaking Changes: 114 Warnings warning [Detail]
    The following breaking changes are detected by comparison with latest preview version:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) '2021-02-12' from the old version.
    Old: Microsoft.BlobStorage/preview/2021-02-12/blob.json#L39:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) '2021-02-12' from the old version.
    Old: Microsoft.BlobStorage/preview/2021-02-12/blob.json#L94:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) '2021-02-12' from the old version.
    Old: Microsoft.BlobStorage/preview/2021-02-12/blob.json#L173:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) '2021-02-12' from the old version.
    Old: Microsoft.BlobStorage/preview/2021-02-12/blob.json#L257:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) '2021-02-12' from the old version.
    Old: Microsoft.BlobStorage/preview/2021-02-12/blob.json#L341:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) '2021-02-12' from the old version.
    Old: Microsoft.BlobStorage/preview/2021-02-12/blob.json#L428:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) '2021-02-12' from the old version.
    Old: Microsoft.BlobStorage/preview/2021-02-12/blob.json#L540:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) '2021-02-12' from the old version.
    Old: Microsoft.BlobStorage/preview/2021-02-12/blob.json#L618:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) '2021-02-12' from the old version.
    Old: Microsoft.BlobStorage/preview/2021-02-12/blob.json#L701:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) '2021-02-12' from the old version.
    Old: Microsoft.BlobStorage/preview/2021-02-12/blob.json#L779:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) '2021-02-12' from the old version.
    Old: Microsoft.BlobStorage/preview/2021-02-12/blob.json#L933:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) '2021-02-12' from the old version.
    Old: Microsoft.BlobStorage/preview/2021-02-12/blob.json#L1016:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) '2021-02-12' from the old version.
    Old: Microsoft.BlobStorage/preview/2021-02-12/blob.json#L1118:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) '2021-02-12' from the old version.
    Old: Microsoft.BlobStorage/preview/2021-02-12/blob.json#L1203:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) '2021-02-12' from the old version.
    Old: Microsoft.BlobStorage/preview/2021-02-12/blob.json#L1311:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) '2021-02-12' from the old version.
    Old: Microsoft.BlobStorage/preview/2021-02-12/blob.json#L1401:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) '2021-02-12' from the old version.
    Old: Microsoft.BlobStorage/preview/2021-02-12/blob.json#L1491:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) '2021-02-12' from the old version.
    Old: Microsoft.BlobStorage/preview/2021-02-12/blob.json#L1582:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) '2021-02-12' from the old version.
    Old: Microsoft.BlobStorage/preview/2021-02-12/blob.json#L1708:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) '2021-02-12' from the old version.
    Old: Microsoft.BlobStorage/preview/2021-02-12/blob.json#L1826:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) '2021-02-12' from the old version.
    Old: Microsoft.BlobStorage/preview/2021-02-12/blob.json#L1949:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) '2021-02-12' from the old version.
    Old: Microsoft.BlobStorage/preview/2021-02-12/blob.json#L2072:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) '2021-02-12' from the old version.
    Old: Microsoft.BlobStorage/preview/2021-02-12/blob.json#L2198:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) '2021-02-12' from the old version.
    Old: Microsoft.BlobStorage/preview/2021-02-12/blob.json#L2304:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) '2021-02-12' from the old version.
    Old: Microsoft.BlobStorage/preview/2021-02-12/blob.json#L2413:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) '2021-02-12' from the old version.
    Old: Microsoft.BlobStorage/preview/2021-02-12/blob.json#L2523:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) '2021-02-12' from the old version.
    Old: Microsoft.BlobStorage/preview/2021-02-12/blob.json#L3140:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) '2021-02-12' from the old version.
    Old: Microsoft.BlobStorage/preview/2021-02-12/blob.json#L3612:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) '2021-02-12' from the old version.
    Old: Microsoft.BlobStorage/preview/2021-02-12/blob.json#L3807:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) '2021-02-12' from the old version.
    Old: Microsoft.BlobStorage/preview/2021-02-12/blob.json#L3993:9
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation

    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Nov 15, 2021

    Swagger pipeline restarted successfully, please wait for status update in this comment.

    @openapi-workflow-bot
    Copy link

    Hi @seanmcc-msft, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

    TaskHow to fixPrioritySupport (Microsoft alias)
    AvocadoFix-AvocadoHighruowan
    Semantic validationFix-SemanticValidation-ErrorHighraychen, jianyxi
    Model validationFix-ModelValidation-ErrorHighraychen,jianyxi
    LintDiffFix-LintDiffhighjianyxi, ruoxuan
    If you need further help, please feedback via swagger feedback."

    * Added File Rename
    
    * Added directory rename
    
    * Removed metadata from Rename File/Directory
    
    * update
    
    * Fixed issue in directory rename
    
    * Removed content type for Rename Directory
    @seanmcc-msft seanmcc-msft marked this pull request as ready for review November 16, 2021 20:59
    @tjprescott tjprescott merged commit 564d013 into main Nov 17, 2021
    @seanmcc-msft seanmcc-msft deleted the feature/storage/stg81 branch December 14, 2021 20:57
    LeiWang3 pushed a commit to LeiWang3/azure-rest-api-specs that referenced this pull request Mar 31, 2022
    * Added 2021-04-10 service version for files (Azure#16556)
    
    * Added 2021-04-10 service version for blobs (Azure#16624)
    
    * Added Container Filter Blobs by Tag (Azure#16627)
    
    * Added Rename Share File/Directory (Azure#16558)
    
    * Added File Rename
    
    * Added directory rename
    
    * Removed metadata from Rename File/Directory
    
    * update
    
    * Fixed issue in directory rename
    
    * Removed content type for Rename Directory
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants