Add VMSS filter to List VMs #16796
Closed
Add VMSS filter to List VMs #16796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xielexie
requested review from
dkulkarni-ms,
grizzlytheodore,
haagha,
hyonholee,
madewithsmiles,
MS-syh2qs and
Sandido
as code owners
|
Hi, @xielexie Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
ghost
added
the
customer-reported
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
The order of parameter 'statusOnly' was changed. New: Microsoft.Compute/stable/2021-07-01/compute.json#L3550:9 Old: Microsoft.Compute/stable/2021-07-01/compute.json#L3543:9 |
|
The optional parameter '$filter' was added in the new version. New: Microsoft.Compute/stable/2021-07-01/compute.json#L3516:11 |
|
The optional parameter '$filter' was added in the new version. New: Microsoft.Compute/stable/2021-07-01/compute.json#L3551:11 |
️🔄LintDiff inProgress [Detail]
️⚠️Avocado: 1 Warnings warning [Detail]
| Rule | Message |
|---|---|
| The default tag contains multiple API versions swaggers. readme: specification/compute/resource-manager/readme.md tag: specification/compute/resource-manager/readme.md#tag-package-2021-07-01 |
️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
|
Thank you for your contribution xielexie! We will review the pull request and get back to you soon. |
Swagger Generation Artifacts
|
| Rule | Message |
|---|---|
|
"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=264812&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Run.ps1 failed with exit code 128 " |
️❌SDK Breaking Change Tracking failed [Detail]
Breaking Changes Tracking
❌azure-sdk-for-python-track2 - track2_azure-mgmt-compute - 23.1.0+ Model RestorePoint no longer has parameter provisioning_details + Operation VirtualMachinesOperations.list has a new signature + Operation VirtualMachinesOperations.list_all has a new signature
️✔️azure-sdk-for-go - profiles/2020-09-01/compute/mgmt/compute - v59.2.0️✔️azure-sdk-for-go - containerservice/mgmt/2017-01-31/containerservice - v59.2.0️✔️azure-sdk-for-go - containerservice/mgmt/2016-09-30/containerservice - v59.2.0️✔️azure-sdk-for-go - containerservice/mgmt/2016-03-30/containerservice - v59.2.0❌azure-sdk-for-go - compute/mgmt/2021-07-01/compute - v59.2.0+ Field `ProvisioningDetails` of struct `RestorePointProperties` has been removed + Function `VirtualMachinesClient.ListAllComplete` parameter(s) have been changed from `(context.Context, string)` to `(context.Context, string, string)` + Function `VirtualMachinesClient.ListAllPreparer` parameter(s) have been changed from `(context.Context, string)` to `(context.Context, string, string)` + Function `VirtualMachinesClient.ListAll` parameter(s) have been changed from `(context.Context, string)` to `(context.Context, string, string)` + Function `VirtualMachinesClient.ListComplete` parameter(s) have been changed from `(context.Context, string)` to `(context.Context, string, string)` + Function `VirtualMachinesClient.ListPreparer` parameter(s) have been changed from `(context.Context, string)` to `(context.Context, string, string)` + Function `VirtualMachinesClient.List` parameter(s) have been changed from `(context.Context, string)` to `(context.Context, string, string)` + Struct `RestorePointProvisioningDetails` has been removed
❌azure-sdk-for-go - compute/mgmt/2021-04-01/compute - v59.2.0+ Field `ProvisioningDetails` of struct `RestorePointProperties` has been removed + Struct `RestorePointProvisioningDetails` has been removed + Type of `OrchestrationServiceStateInput.ServiceName` has been changed from `*string` to `OrchestrationServiceNames`
❌azure-sdk-for-go - compute/mgmt/2021-03-01/compute - v59.2.0+ Field `ConsistencyMode` of struct `RestorePoint` has been removed + Field `ExcludeDisks` of struct `RestorePoint` has been removed + Field `ProvisioningDetails` of struct `RestorePoint` has been removed + Field `ProvisioningState` of struct `RestorePoint` has been removed + Field `PublicIPAddressSkuName` of struct `PublicIPAddressSku` has been removed + Field `PublicIPAddressSkuTier` of struct `PublicIPAddressSku` has been removed + Field `SourceMetadata` of struct `RestorePoint` has been removed + Struct `RestorePointProvisioningDetails` has been removed + Type of `OrchestrationServiceStateInput.ServiceName` has been changed from `*string` to `OrchestrationServiceNames`
️✔️azure-sdk-for-go - compute/mgmt/2020-12-01/compute - v59.2.0❌azure-sdk-for-go - compute/mgmt/2020-06-30/compute - v59.2.0+ Field `ContentType` of struct `GalleryApplicationVersionPublishingProfile` has been removed + Field `FileName` of struct `UserArtifactSource` has been removed
❌azure-sdk-for-go - compute/mgmt/2020-06-01/compute - v59.2.0+ Field `ContentType` of struct `GalleryApplicationVersionPublishingProfile` has been removed + Field `FileName` of struct `UserArtifactSource` has been removed
❌azure-sdk-for-go - compute/mgmt/2019-12-01/compute - v59.2.0+ Field `ContentType` of struct `GalleryApplicationVersionPublishingProfile` has been removed + Field `FileName` of struct `UserArtifactSource` has been removed
❌azure-sdk-for-go - compute/mgmt/2019-07-01/compute - v59.2.0+ Field `ContentType` of struct `GalleryApplicationVersionPublishingProfile` has been removed + Field `FileName` of struct `UserArtifactSource` has been removed
❌azure-sdk-for-go - compute/mgmt/2019-03-01/compute - v59.2.0+ Field `ContentType` of struct `GalleryApplicationVersionPublishingProfile` has been removed + Field `FileName` of struct `UserArtifactSource` has been removed
️✔️azure-sdk-for-go - compute/mgmt/2018-10-01/compute - v59.2.0️✔️azure-sdk-for-go - compute/mgmt/2018-06-01/compute - v59.2.0️✔️azure-sdk-for-go - compute/mgmt/2018-04-01/compute - v59.2.0️✔️azure-sdk-for-go - compute/mgmt/2017-12-01/compute - v59.2.0️✔️azure-sdk-for-go - compute/mgmt/2017-09-01/skus - v59.2.0️✔️azure-sdk-for-go - compute/mgmt/2017-03-30/compute - v59.2.0️✔️azure-sdk-for-go - compute/mgmt/2016-03-30/compute - v59.2.0️✔️azure-sdk-for-go - compute/mgmt/2015-06-15/compute - v59.2.0️✔️azure-sdk-for-go - preview/containerservice/mgmt/2015-11-01-preview/containerservice - v59.2.0️✔️azure-sdk-for-go - preview/compute/mgmt/2020-10-01-preview/compute - v59.2.0️✔️azure-sdk-for-go - preview/compute/mgmt/2016-04-30-preview/compute - v59.2.0️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from 7ea0e2e9cb50914e9e428f6dad9adc9dcef0212f. SDK Automation 14.0.0warn Skip initScript due to not configured command sudo apt-get install -y dotnet-sdk-5.0 command autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/compute/resource-manager/readme.md cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied
️✔️Microsoft.Azure.Management.Compute [View full logs] [Preview SDK Changes]
️⚠️ azure-sdk-for-python-track2 warning [Detail]
⚠️Warning [Logs] Generate from 7ea0e2e9cb50914e9e428f6dad9adc9dcef0212f. SDK Automation 14.0.0command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
️✔️track2_azure-mgmt-compute [View full logs] [Preview SDK Changes] Breaking Change Detectedinfo [Changelog] **Features** info [Changelog] info [Changelog] - Model RestorePoint has a new parameter time_created info [Changelog] info [Changelog] **Breaking changes** info [Changelog] info [Changelog] - Operation VirtualMachinesOperations.list has a new signature info [Changelog] - Operation VirtualMachinesOperations.list_all has a new signature info [Changelog] - Model RestorePoint no longer has parameter provisioning_details
️⚠️ azure-sdk-for-java warning [Detail]
⚠️Warning [Logs] Generate from 7ea0e2e9cb50914e9e428f6dad9adc9dcef0212f. SDK Automation 14.0.0command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json cmderr [generate.py] 2021-11-18 07:14:46 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-compute-generated" cmderr [generate.py] 2021-11-18 07:14:46 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1" cmderr [generate.py] 2021-11-18 07:14:46 INFO autorest --version=3.6.0 --use=@autorest/[email protected] --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/compute/azure-resourcemanager-compute-generated --java.namespace=com.azure.resourcemanager.compute.generated --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --generate-samples --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/compute/resource-manager/readme.md cmderr [generate.py] 2021-11-18 07:16:25 INFO [CI][Success] Write to ci.yml cmderr [generate.py] 2021-11-18 07:16:25 INFO [POM][Process] dealing with pom.xml cmderr [generate.py] 2021-11-18 07:16:25 INFO [POM][Skip] pom already has module azure-resourcemanager-compute-generated cmderr [generate.py] 2021-11-18 07:16:25 INFO [POM][Success] Write to pom.xml cmderr [generate.py] 2021-11-18 07:16:25 INFO [POM][Process] dealing with root pom cmderr [generate.py] 2021-11-18 07:16:25 INFO [POM][Success] Write to root pom
️✔️azure-resourcemanager-compute-generated [View full logs] [Preview SDK Changes]- pom.xml
- azure-resourcemanager-compute-generated-1.0.0-beta.1-javadoc.jar
- azure-resourcemanager-compute-generated-1.0.0-beta.1-sources.jar
- azure-resourcemanager-compute-generated-1.0.0-beta.1.jar
cmderr [Inst] 2021-11-18 07:20:58 DEBUG Got artifact_id: azure-resourcemanager-compute-generated cmderr [Inst] 2021-11-18 07:20:58 DEBUG Got artifact: pom.xml cmderr [Inst] 2021-11-18 07:20:58 DEBUG Got artifact: azure-resourcemanager-compute-generated-1.0.0-beta.1-javadoc.jar cmderr [Inst] 2021-11-18 07:20:58 DEBUG Got artifact: azure-resourcemanager-compute-generated-1.0.0-beta.1-sources.jar cmderr [Inst] 2021-11-18 07:20:58 DEBUG Got artifact: azure-resourcemanager-compute-generated-1.0.0-beta.1.jar cmderr [Inst] 2021-11-18 07:20:58 DEBUG Match jar package: azure-resourcemanager-compute-generated-1.0.0-beta.1.jar cmderr [Inst] 2021-11-18 07:20:58 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/16796/azure-sdk-for-java/azure-resourcemanager-compute-generated/azure-resourcemanager-compute-generated-1.0.0-beta.1.jar\" -o azure-resourcemanager-compute-generated-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-compute-generated -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-compute-generated-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true ```"}
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from 7ea0e2e9cb50914e9e428f6dad9adc9dcef0212f. SDK Automation 14.0.0warn Skip initScript due to not configured command autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/compute/resource-manager/readme.md
️✔️@azure/arm-compute [View full logs] [Preview SDK Changes]cmderr [npmPack] loaded rollup.config.js with warnings cmderr [npmPack] (!) Unused external imports cmderr [npmPack] default imported from external module 'rollup' but never used cmderr [npmPack] ./esm/computeManagementClient.js → ./dist/arm-compute.js... cmderr [npmPack] created ./dist/arm-compute.js in 1.4s
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from 7ea0e2e9cb50914e9e428f6dad9adc9dcef0212f. SDK Automation 14.0.0command sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️profiles/2020-09-01/compute/mgmt/compute [View full logs] [Preview SDK Changes]info [Changelog] This is a new package
️✔️containerservice/mgmt/2017-01-31/containerservice [View full logs]info [Changelog] No exported changes
️✔️containerservice/mgmt/2016-09-30/containerservice [View full logs]info [Changelog] No exported changes
️✔️containerservice/mgmt/2016-03-30/containerservice [View full logs]info [Changelog] No exported changes
- Only show 5 items here, please refer to log for details.
️✔️compute/mgmt/2021-07-01/compute [View full logs] Breaking Change Detectedinfo [Changelog] info [Changelog] - New field `TimeCreated` in struct `RestorePointProperties` info [Changelog] info [Changelog] Total 9 breaking change(s), 1 additive change(s). info [Changelog]
- Only show 5 items here, please refer to log for details.
️✔️compute/mgmt/2021-04-01/compute [View full logs] Breaking Change Detectedinfo [Changelog] - New field `SupportedCapabilities` in struct `DiskProperties` info [Changelog] - New field `PublicNetworkAccess` in struct `DiskProperties` info [Changelog] info [Changelog] Total 4 breaking change(s), 16 additive change(s). info [Changelog]
- Only show 5 items here, please refer to log for details.
️✔️compute/mgmt/2021-03-01/compute [View full logs] Breaking Change Detectedinfo [Changelog] - New field `Name` in struct `PublicIPAddressSku` info [Changelog] - New field `Tier` in struct `PublicIPAddressSku` info [Changelog] info [Changelog] Total 5 breaking change(s), 21 additive change(s). info [Changelog]
️✔️compute/mgmt/2020-12-01/compute [View full logs]info [Changelog] No exported changes
- Only show 5 items here, please refer to log for details.
️✔️compute/mgmt/2020-06-30/compute [View full logs] Breaking Change Detectedinfo [Changelog] - New field `DefaultConfigurationLink` in struct `UserArtifactSource` info [Changelog] - New field `EnableFpga` in struct `VirtualMachineScaleSetNetworkConfigurationProperties` info [Changelog] info [Changelog] Total 2 breaking change(s), 9 additive change(s). info [Changelog]
- Only show 5 items here, please refer to log for details.
️✔️compute/mgmt/2020-06-01/compute [View full logs] Breaking Change Detectedinfo [Changelog] - New field `GroupByClientApplicationID` in struct `ThrottledRequestsInput` info [Changelog] - New field `GroupByUserAgent` in struct `ThrottledRequestsInput` info [Changelog] info [Changelog] Total 2 breaking change(s), 9 additive change(s). info [Changelog]
- Only show 5 items here, please refer to log for details.
️✔️compute/mgmt/2019-12-01/compute [View full logs] Breaking Change Detectedinfo [Changelog] - New field `ManageActions` in struct `GalleryApplicationVersionPublishingProfile` info [Changelog] - New field `DefaultConfigurationLink` in struct `UserArtifactSource` info [Changelog] info [Changelog] Total 2 breaking change(s), 4 additive change(s). info [Changelog]
- Only show 5 items here, please refer to log for details.
️✔️compute/mgmt/2019-07-01/compute [View full logs] Breaking Change Detectedinfo [Changelog] - New field `ManageActions` in struct `GalleryApplicationVersionPublishingProfile` info [Changelog] - New field `DefaultConfigurationLink` in struct `UserArtifactSource` info [Changelog] info [Changelog] Total 2 breaking change(s), 4 additive change(s). info [Changelog]
- Only show 5 items here, please refer to log for details.
️✔️compute/mgmt/2019-03-01/compute [View full logs] Breaking Change Detectedinfo [Changelog] - New field `ManageActions` in struct `GalleryApplicationVersionPublishingProfile` info [Changelog] - New field `DefaultConfigurationLink` in struct `UserArtifactSource` info [Changelog] info [Changelog] Total 2 breaking change(s), 4 additive change(s). info [Changelog]
️✔️compute/mgmt/2018-10-01/compute [View full logs]info [Changelog] No exported changes
️✔️compute/mgmt/2018-06-01/compute [View full logs]info [Changelog] No exported changes
️✔️compute/mgmt/2018-04-01/compute [View full logs]info [Changelog] No exported changes
️✔️compute/mgmt/2017-12-01/compute [View full logs]info [Changelog] No exported changes
️✔️compute/mgmt/2017-09-01/skus [View full logs]info [Changelog] No exported changes
️✔️compute/mgmt/2017-03-30/compute [View full logs]info [Changelog] No exported changes
️✔️compute/mgmt/2016-03-30/compute [View full logs]info [Changelog] No exported changes
️✔️compute/mgmt/2015-06-15/compute [View full logs]info [Changelog] No exported changes
️✔️preview/containerservice/mgmt/2015-11-01-preview/containerservice [View full logs]info [Changelog] No exported changes
️✔️preview/compute/mgmt/2020-10-01-preview/compute [View full logs]info [Changelog] No exported changes
️✔️preview/compute/mgmt/2016-04-30-preview/compute [View full logs]info [Changelog] No exported changes
️❌ azure-sdk-for-go-track2 failed [Detail]
❌Failed [Logs] Generate from 7ea0e2e9cb50914e9e428f6dad9adc9dcef0212f. SDK Automation 14.0.0command sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json cmderr [generator automation-v2] [ERROR] total 1 error(s): cmderr [generator automation-v2] [ERROR] failed to execute `go generate` 'go: github.com/Azure/azure-sdk-for-go/sdk/[email protected] requires cmderr [generator automation-v2] [ERROR] github.com/Azure/azure-sdk-for-go/sdk/[email protected]: missing go.sum entry; to add it: cmderr [generator automation-v2] [ERROR] go mod download github.com/Azure/azure-sdk-for-go/sdk/internal cmderr [generator automation-v2] [ERROR] ': exit status 1 error Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go]: generator automation-v2 warn Skip package processing as generation is failed
️⚠️ azure-resource-manager-schemas warning [Detail]
⚠️Warning [Logs] Generate from 7ea0e2e9cb50914e9e428f6dad9adc9dcef0212f. Schema Automation 14.0.0command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json cmderr [initScript.sh] WARN old lockfile cmderr [initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm, cmderr [initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry. cmderr [initScript.sh] npm WARN old lockfile cmderr [initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient... cmderr [initScript.sh] npm WARN old lockfile warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json warn No file changes detected after generation
️✔️compute [View full logs]
|
Hi @xielexie, Your PR has some issues. Please fix the CI sequentially by following the order of
|
|
Hi @xielexie, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
|
NewApiVersionRequired reason: |
This was referenced Nov 17, 2021
sds6
reviewed
Nov 17, 2021
| "in": "query", | ||
| "required": false, | ||
| "type": "string", | ||
| "description": "The filter to apply to the operation. Allowed values are 'startswith(instanceView/statuses/code, 'PowerState') eq true', 'properties/latestModelApplied eq true', 'properties/latestModelApplied eq false'." |
There was a problem hiding this comment.
As mentioned here https://msazure.visualstudio.com/One/_workitems/edit/12097662 . The filter param is different.
GET https://management.azure.com/subscriptions/576f5e67-b043-4ec9-81e9-47c7e8692cc4/providers/Microsoft.compute/virtualMachines?api-version=2021-07-01&**$filter='virtualMachineScaleSet/id'** eq '/subscriptions/576f5e67-b043-4ec9-81e9-47c7e8692cc4/resourceGroups/CUSTOMDATATESTCANARY/providers/Microsoft.Compute/virtualMachineScaleSets/customdataBicep2'
So the filter is : $filter='virtualMachineScaleSet/id' eq vmssArmUri
There was a problem hiding this comment.
I have changed description to "The filter to apply to the operation. Allowed value is 'virtualMachineScaleSet/id' eq VmssArmURI." if you think is not reasonable. please let me know.
sds6
reviewed
Nov 18, 2021
| @@ -3513,6 +3513,13 @@ | |||
| "type": "string", | |||
| "description": "The name of the resource group." | |||
| }, | |||
| { | |||
| "name": "$filter", | |||
| "in": "query", | |||
There was a problem hiding this comment.
This is for older API version. We need to add for new one
|
Hi, @xielexie. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
|
Hey @xielexie could you please fix the failed pipelines? You can ignore the failure in azure-sdk-for-go-track2, that is an internal error inside the pipeline and already fixed. |
|
Hi, @xielexie. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
|
Hi, @xielexie. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
|
Hi, @xielexie. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
|
Hi, @xielexie. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
|
I notice the source repository of this PR has been deleted. I am going to close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
12/2021
12/2021
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.