Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ContentCertificateProperties live validation error #17072

Merged
merged 2 commits into from
Dec 21, 2021

Conversation

Descatles
Copy link
Contributor

@Descatles Descatles commented Dec 14, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

The Content in ContentCertificateProperties is required in request and hided in response by design.
It has no customer impact because it is just an error on swagger and we do not need to update our backend code.
The behavior customers see is always require Content property in request and no Content property in response.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @Descatles Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Dec 14, 2021

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.

    ️⚠️LintDiff: 0 Warnings warning [Detail]
    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    R4009 - RequiredReadOnlySystemData The response of operation:'Services_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppPlatform/preview/2021-09-01-preview/appplatform.json#L20
    R4009 - RequiredReadOnlySystemData The response of operation:'ConfigServers_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppPlatform/preview/2021-09-01-preview/appplatform.json#L509
    R4009 - RequiredReadOnlySystemData The response of operation:'MonitoringSettings_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppPlatform/preview/2021-09-01-preview/appplatform.json#L730
    R4009 - RequiredReadOnlySystemData The response of operation:'Apps_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppPlatform/preview/2021-09-01-preview/appplatform.json#L890
    R4009 - RequiredReadOnlySystemData The response of operation:'Bindings_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppPlatform/preview/2021-09-01-preview/appplatform.json#L1212
    R4009 - RequiredReadOnlySystemData The response of operation:'Certificates_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppPlatform/preview/2021-09-01-preview/appplatform.json#L1705
    R4009 - RequiredReadOnlySystemData The response of operation:'CustomDomains_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppPlatform/preview/2021-09-01-preview/appplatform.json#L1965
    R4009 - RequiredReadOnlySystemData The response of operation:'Deployments_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppPlatform/preview/2021-09-01-preview/appplatform.json#L2304
    R4009 - RequiredReadOnlySystemData The response of operation:'Services_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppPlatform/preview/2021-09-01-preview/appplatform.json#L60
    R4009 - RequiredReadOnlySystemData The response of operation:'ConfigServers_UpdatePut' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppPlatform/preview/2021-09-01-preview/appplatform.json#L549
    R4009 - RequiredReadOnlySystemData The response of operation:'MonitoringSettings_UpdatePut' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppPlatform/preview/2021-09-01-preview/appplatform.json#L770
    R4009 - RequiredReadOnlySystemData The response of operation:'Apps_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppPlatform/preview/2021-09-01-preview/appplatform.json#L940
    R4009 - RequiredReadOnlySystemData The response of operation:'Bindings_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppPlatform/preview/2021-09-01-preview/appplatform.json#L1258
    R4009 - RequiredReadOnlySystemData The response of operation:'Certificates_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppPlatform/preview/2021-09-01-preview/appplatform.json#L1748
    R4009 - RequiredReadOnlySystemData The response of operation:'CustomDomains_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppPlatform/preview/2021-09-01-preview/appplatform.json#L2011
    R4009 - RequiredReadOnlySystemData The response of operation:'Deployments_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppPlatform/preview/2021-09-01-preview/appplatform.json#L2353
    R4009 - RequiredReadOnlySystemData The response of operation:'Services_Update' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppPlatform/preview/2021-09-01-preview/appplatform.json#L172
    R4009 - RequiredReadOnlySystemData The response of operation:'ConfigServers_UpdatePatch' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppPlatform/preview/2021-09-01-preview/appplatform.json#L608
    R4009 - RequiredReadOnlySystemData The response of operation:'MonitoringSettings_UpdatePatch' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppPlatform/preview/2021-09-01-preview/appplatform.json#L829
    R4009 - RequiredReadOnlySystemData The response of operation:'Apps_Update' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppPlatform/preview/2021-09-01-preview/appplatform.json#L1058
    R4009 - RequiredReadOnlySystemData The response of operation:'Bindings_Update' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppPlatform/preview/2021-09-01-preview/appplatform.json#L1382
    R4009 - RequiredReadOnlySystemData The response of operation:'CustomDomains_Update' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppPlatform/preview/2021-09-01-preview/appplatform.json#L2135
    R4009 - RequiredReadOnlySystemData The response of operation:'Deployments_Update' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppPlatform/preview/2021-09-01-preview/appplatform.json#L2480
    R4011 - DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
    Location: Microsoft.AppPlatform/preview/2021-09-01-preview/appplatform.json#L148
    R4037 - MissingTypeObject The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.AppPlatform/preview/2021-09-01-preview/appplatform.json#L5363
    R4037 - MissingTypeObject The schema 'CloudErrorBody' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.AppPlatform/preview/2021-09-01-preview/appplatform.json#L5373
    ⚠️ R1001 - OperationIdNounVerb Per the Noun_Verb convention for Operation Ids, the noun 'RuntimeVersions' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.AppPlatform/preview/2021-09-01-preview/appplatform.json#L3179
    ⚠️ R1003 - ListInOperationName Since operation 'ConfigServers_Validate' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.AppPlatform/preview/2021-09-01-preview/appplatform.json#L674
    ⚠️ R1006 - PutInOperationName 'PUT' operation 'ConfigServers_UpdatePut' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.AppPlatform/preview/2021-09-01-preview/appplatform.json#L554
    ⚠️ R1006 - PutInOperationName 'PUT' operation 'MonitoringSettings_UpdatePut' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.AppPlatform/preview/2021-09-01-preview/appplatform.json#L775
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation

    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Dec 14, 2021

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-go-track2 - armappplatform - 0.2.1
    ️✔️azure-sdk-for-go - appplatform/mgmt/2020-07-01/appplatform - v60.1.0
    ️✔️azure-sdk-for-go - preview/appplatform/mgmt/2021-09-01-preview/appplatform - v60.1.0
    ️✔️azure-sdk-for-go - preview/appplatform/mgmt/2021-06-01-preview/appplatform - v60.1.0
    ️✔️azure-sdk-for-go - preview/appplatform/mgmt/2020-11-01-preview/appplatform - v60.1.0
    ️✔️azure-sdk-for-go - preview/appplatform/mgmt/2019-05-01-preview/appplatform - v60.1.0
    azure-sdk-for-python-track2 - track2_azure-mgmt-appplatform - Approved - 6.1.0
    ️❌ azure-powershell failed [Detail]
    • Failed [Logs]Release - Generate from e05da83. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
      Resource not accessible by integration
      HttpError: Resource not accessible by integration
          at /home/vsts/work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/@[email protected]/node_modules/@octokit/request/dist-node/index.js:86:21
          at processTicksAndRejections (internal/process/task_queues.js:95:5)
          at async workflowPkgUpdatePR (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflowPackage.js:346:21)
          at async Object.exports.workflowPkgMain (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflowPackage.js:41:5)
          at async workflowHandleReadmeMd (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:172:9)
          at async Object.exports.workflowMain (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:83:9)
          at async Object.exports.sdkAutoMain (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/entrypoint.js:152:13)
          at async /home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/cli/cli.js:20:18
    • ️✔️Az.AppPlatform [View full logs
      error	Fatal error: Resource not accessible by integration
      error	The following packages are still pending:
      error		Az.AppPlatform
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from e05da83. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh] npm notice
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.1.2 -> 8.3.0
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.3.0>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-appplatform [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added operation DeploymentsOperations.begin_generate_heap_dump
      info	[Changelog]   - Added operation DeploymentsOperations.begin_generate_thread_dump
      info	[Changelog]   - Added operation DeploymentsOperations.begin_start_jfr
      info	[Changelog]   - Added operation ServicesOperations.begin_start
      info	[Changelog]   - Added operation ServicesOperations.begin_stop
      info	[Changelog]   - Added operation group StoragesOperations
      info	[Changelog]   - Model AppResourceProperties has a new parameter custom_persistent_disks
      info	[Changelog]   - Model AppResourceProperties has a new parameter loaded_certificates
      info	[Changelog]   - Model ClusterResourceProperties has a new parameter power_state
      info	[Changelog]   - Model DeploymentSettings has a new parameter container_probe_settings
      info	[Changelog]   - Model MetricSpecification has a new parameter source_mdm_namespace
      info	[Changelog]   - Model OperationDetail has a new parameter action_type
      info	[Changelog]
      info	[Changelog] **Breaking changes**
      info	[Changelog]
      info	[Changelog]   - Model CertificateProperties has a new required parameter type
      info	[Changelog]   - Model CertificateProperties no longer has parameter cert_version
      info	[Changelog]   - Model CertificateProperties no longer has parameter key_vault_cert_name
      info	[Changelog]   - Model CertificateProperties no longer has parameter vault_uri
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from e05da83. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-12-21 02:37:13 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-appplatform-generated"
      cmderr	[generate.py] 2021-12-21 02:37:13 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
      cmderr	[generate.py] 2021-12-21 02:37:13 INFO autorest --version=3.6.6 --use=@autorest/[email protected] --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/appplatform/azure-resourcemanager-appplatform-generated --java.namespace=com.azure.resourcemanager.appplatform.generated   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --generate-samples --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/appplatform/resource-manager/readme.md
      cmderr	[generate.py] 2021-12-21 02:37:53 INFO [CI][Success] Write to ci.yml
      cmderr	[generate.py] 2021-12-21 02:37:53 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2021-12-21 02:37:53 INFO [POM][Skip] pom already has module azure-resourcemanager-appplatform-generated
      cmderr	[generate.py] 2021-12-21 02:37:53 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2021-12-21 02:37:53 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2021-12-21 02:37:53 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-appplatform-generated [View full logs]  [Release SDK Changes]
      cmderr	[Inst] 2021-12-21 02:39:46 DEBUG Got artifact_id: azure-resourcemanager-appplatform-generated
      cmderr	[Inst] 2021-12-21 02:39:46 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-12-21 02:39:46 DEBUG Got artifact: azure-resourcemanager-appplatform-generated-1.0.0-beta.1-javadoc.jar
      cmderr	[Inst] 2021-12-21 02:39:46 DEBUG Got artifact: azure-resourcemanager-appplatform-generated-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-12-21 02:39:46 DEBUG Match jar package: azure-resourcemanager-appplatform-generated-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-12-21 02:39:46 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/17072/azure-sdk-for-java/azure-resourcemanager-appplatform-generated/azure-resourcemanager-appplatform-generated-1.0.0-beta.1.jar\" -o azure-resourcemanager-appplatform-generated-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-appplatform-generated -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-appplatform-generated-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️❌ azure-sdk-for-net failed [Detail]
    • Failed [Logs]Release - Generate from e05da83. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-5.0
      command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/appplatform/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • Microsoft.Azure.Management.AppPlatform [View full logs]  [Release SDK Changes]
      cmderr	[msbuild] Could not execute because the application was not found or a compatible .NET SDK is not installed.
      cmderr	[msbuild] Possible reasons for this include:
      cmderr	[msbuild]   * You intended to execute a .NET program:
      cmderr	[msbuild]       The application 'msbuild' does not exist.
      cmderr	[msbuild]   * You intended to execute a .NET SDK command:
      cmderr	[msbuild]       A compatible installed .NET SDK for global.json version [6.0.100] from [/home/vsts/work/1/s/azure-sdk-for-net/global.json] was not found.
      cmderr	[msbuild]       Install the [6.0.100] .NET SDK or update [/home/vsts/work/1/s/azure-sdk-for-net/global.json] with an installed .NET SDK:
      error	Script return with result [failed] code [145] signal [null] cwd [azure-sdk-for-net]: dotnet
    ️⚠️ azure-sdk-for-js warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from e05da83. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      cmderr	[automation_init.sh]  WARN deprecated [email protected]: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
      cmderr	[automation_init.sh]  @opentelemetry/[email protected]: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
      cmderr	[automation_init.sh] notice created a lockfile as package-lock.json. You should commit this file.
      cmderr	[automation_init.sh] npm WARN @octokit/[email protected] requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️track2_@azure/arm-appplatform [View full logs]  [Release SDK Changes]
      info	[Changelog]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from e05da83. SDK Automation 14.0.0
      command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️appplatform/mgmt/2020-07-01/appplatform [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New const `Internal`
      info	[Changelog] - New const `Inbound`
      info	[Changelog] - New const `Outbound`
      info	[Changelog] - New function `RequiredTraffic.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `PossibleTrafficDirectionValues() []TrafficDirection`
      info	[Changelog] - New function `PossibleActionTypeValues() []ActionType`
      info	[Changelog] - New function `OperationDetail.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New struct `RequiredTraffic`
      info	[Changelog] - New field `RequiredTraffics` in struct `NetworkProfile`
      info	[Changelog] - New field `ActionType` in struct `OperationDetail`
      info	[Changelog] - New field `ToBeExportedForShoebox` in struct `MetricDimension`
      info	[Changelog] - New field `SourceMdmNamespace` in struct `MetricSpecification`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 13 additive change(s).
    • ️✔️preview/appplatform/mgmt/2021-09-01-preview/appplatform [View full logs
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New const `ActionTypeInternal`
      info	[Changelog] - New function `PossibleActionTypeValues() []ActionType`
      info	[Changelog] - New function `OperationDetail.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New field `ActionType` in struct `OperationDetail`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 4 additive change(s).
    • ️✔️preview/appplatform/mgmt/2021-06-01-preview/appplatform [View full logs
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New const `ActionTypeInternal`
      info	[Changelog] - New function `PossibleActionTypeValues() []ActionType`
      info	[Changelog] - New function `OperationDetail.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New field `ActionType` in struct `OperationDetail`
      info	[Changelog] - New field `SourceMdmNamespace` in struct `MetricSpecification`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 5 additive change(s).
    • ️✔️preview/appplatform/mgmt/2020-11-01-preview/appplatform [View full logs
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New const `Internal`
      info	[Changelog] - New function `PossibleActionTypeValues() []ActionType`
      info	[Changelog] - New function `OperationDetail.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New field `SourceMdmNamespace` in struct `MetricSpecification`
      info	[Changelog] - New field `ToBeExportedForShoebox` in struct `MetricDimension`
      info	[Changelog] - New field `ActionType` in struct `OperationDetail`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 6 additive change(s).
    • ️✔️preview/appplatform/mgmt/2019-05-01-preview/appplatform [View full logs
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New const `DeploymentResourceProvisioningStateDeleting`
      info	[Changelog] - New const `Deleting`
      info	[Changelog] - New const `Inbound`
      info	[Changelog] - New const `Outbound`
      info	[Changelog] - New const `Internal`
      info	[Changelog] - New function `RequiredTraffic.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `OperationDetail.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `PossibleTrafficDirectionValues() []TrafficDirection`
      info	[Changelog] - New function `PossibleActionTypeValues() []ActionType`
      info	[Changelog] - New struct `RequiredTraffic`
      info	[Changelog] - New field `SourceMdmNamespace` in struct `MetricSpecification`
      info	[Changelog] - New field `RequiredTraffics` in struct `NetworkProfile`
      info	[Changelog] - New field `ToBeExportedForShoebox` in struct `MetricDimension`
      info	[Changelog] - New field `ActionType` in struct `OperationDetail`
      info	[Changelog] - New field `Sku` in struct `DeploymentResource`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 16 additive change(s).
    ️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from e05da83. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armappplatform [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New const `ActionTypeInternal`
      info	[Changelog] - New function `PossibleActionTypeValues() []ActionType`
      info	[Changelog] - New function `ActionType.ToPtr() *ActionType`
      info	[Changelog] - New field `ActionType` in struct `OperationDetail`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 4 additive change(s).
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from e05da83. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️appplatform [View full logs]  [Release Schema Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @Descatles, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @openapi-workflow-bot
    Copy link

    Hi @Descatles, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

    @raych1
    Copy link
    Member

    raych1 commented Dec 15, 2021

    @Descatles , can you get breaking change review approved?

    LeiWang3 pushed a commit to LeiWang3/azure-rest-api-specs that referenced this pull request Mar 31, 2022
    * Fix ContentCertificateProperties live validation error
    
    * Fix Prettier check
    
    Co-authored-by: Wenhao Zhang <[email protected]>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-SdkBreakingChange-Python CI-FixRequiredOnFailure FixS360
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants