From 3ed585868a84b32e1268cfad9a3026919135d64f Mon Sep 17 00:00:00 2001 From: Akshansh Sharma Date: Mon, 18 Apr 2022 15:43:54 +0530 Subject: [PATCH 1/3] add groupids in response --- .../Microsoft.Automation/common/v1/definitions.json | 11 +++++++++++ .../examples/PrivateEndpointConnectionGet.json | 1 + .../examples/PrivateEndpointConnectionListGet.json | 2 ++ .../examples/PrivateEndpointConnectionUpdate.json | 1 + 4 files changed, 15 insertions(+) diff --git a/specification/automation/resource-manager/Microsoft.Automation/common/v1/definitions.json b/specification/automation/resource-manager/Microsoft.Automation/common/v1/definitions.json index c424056228dd..3ce5cdfdc552 100644 --- a/specification/automation/resource-manager/Microsoft.Automation/common/v1/definitions.json +++ b/specification/automation/resource-manager/Microsoft.Automation/common/v1/definitions.json @@ -125,6 +125,10 @@ "$ref": "#/definitions/PrivateEndpointProperty", "description": "Private endpoint which the connection belongs to." }, + "groupIds": { + "$ref": "#/definitions/GroupIdsProperty", + "description": "Gets the groupIds." + }, "privateLinkServiceConnectionState": { "$ref": "#/definitions/PrivateLinkServiceConnectionStateProperty", "description": "Connection State of the Private Endpoint Connection." @@ -141,6 +145,13 @@ } } }, + "GroupIdsProperty": { + "type": "array", + "items": { + "type": "string" + }, + "description": "Gets the groupIds." + }, "PrivateLinkServiceConnectionStateProperty": { "type": "object", "description": "Connection State of the Private Endpoint Connection.", diff --git a/specification/automation/resource-manager/Microsoft.Automation/preview/2020-01-13-preview/examples/PrivateEndpointConnectionGet.json b/specification/automation/resource-manager/Microsoft.Automation/preview/2020-01-13-preview/examples/PrivateEndpointConnectionGet.json index 063308a536f8..ccb1b5efd30e 100644 --- a/specification/automation/resource-manager/Microsoft.Automation/preview/2020-01-13-preview/examples/PrivateEndpointConnectionGet.json +++ b/specification/automation/resource-manager/Microsoft.Automation/preview/2020-01-13-preview/examples/PrivateEndpointConnectionGet.json @@ -16,6 +16,7 @@ "privateEndpoint": { "id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/rg1Network/providers/Microsoft.Network/privateEndpoints/privateEndpointName" }, + "groupIds": ["sql"], "privateLinkServiceConnectionState": { "status": "Approved", "description": "Auto-approved", diff --git a/specification/automation/resource-manager/Microsoft.Automation/preview/2020-01-13-preview/examples/PrivateEndpointConnectionListGet.json b/specification/automation/resource-manager/Microsoft.Automation/preview/2020-01-13-preview/examples/PrivateEndpointConnectionListGet.json index d369f2f02cf0..eb8cb7979e22 100644 --- a/specification/automation/resource-manager/Microsoft.Automation/preview/2020-01-13-preview/examples/PrivateEndpointConnectionListGet.json +++ b/specification/automation/resource-manager/Microsoft.Automation/preview/2020-01-13-preview/examples/PrivateEndpointConnectionListGet.json @@ -17,6 +17,7 @@ "privateEndpoint": { "id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/rg1Network/providers/Microsoft.Network/privateEndpoints/privateEndpointName" }, + "groupIds": ["sql"], "privateLinkServiceConnectionState": { "status": "Approved", "description": "Auto-approved", @@ -32,6 +33,7 @@ "privateEndpoint": { "id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/rg1Network/providers/Microsoft.Network/privateEndpoints/privateEndpointName2" }, + "groupIds": ["sql"], "privateLinkServiceConnectionState": { "status": "Approved", "description": "Auto-approved", diff --git a/specification/automation/resource-manager/Microsoft.Automation/preview/2020-01-13-preview/examples/PrivateEndpointConnectionUpdate.json b/specification/automation/resource-manager/Microsoft.Automation/preview/2020-01-13-preview/examples/PrivateEndpointConnectionUpdate.json index ab7309b28b43..ad9078ea3c22 100644 --- a/specification/automation/resource-manager/Microsoft.Automation/preview/2020-01-13-preview/examples/PrivateEndpointConnectionUpdate.json +++ b/specification/automation/resource-manager/Microsoft.Automation/preview/2020-01-13-preview/examples/PrivateEndpointConnectionUpdate.json @@ -24,6 +24,7 @@ "privateEndpoint": { "id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/rg1Network/providers/Microsoft.Network/privateEndpoints/privateEndpointName" }, + "groupIds": ["sql"], "privateLinkServiceConnectionState": { "status": "Approved", "description": "Auto-approved", From 5c66144eddfb3627c192d33805d0c098539f5f49 Mon Sep 17 00:00:00 2001 From: Akshansh Sharma Date: Tue, 19 Apr 2022 11:00:53 +0530 Subject: [PATCH 2/3] fix prettier issues --- .../examples/PrivateEndpointConnectionGet.json | 4 +++- .../examples/PrivateEndpointConnectionListGet.json | 8 ++++++-- .../examples/PrivateEndpointConnectionUpdate.json | 4 +++- 3 files changed, 12 insertions(+), 4 deletions(-) diff --git a/specification/automation/resource-manager/Microsoft.Automation/preview/2020-01-13-preview/examples/PrivateEndpointConnectionGet.json b/specification/automation/resource-manager/Microsoft.Automation/preview/2020-01-13-preview/examples/PrivateEndpointConnectionGet.json index ccb1b5efd30e..a607dd7e5d20 100644 --- a/specification/automation/resource-manager/Microsoft.Automation/preview/2020-01-13-preview/examples/PrivateEndpointConnectionGet.json +++ b/specification/automation/resource-manager/Microsoft.Automation/preview/2020-01-13-preview/examples/PrivateEndpointConnectionGet.json @@ -16,7 +16,9 @@ "privateEndpoint": { "id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/rg1Network/providers/Microsoft.Network/privateEndpoints/privateEndpointName" }, - "groupIds": ["sql"], + "groupIds": [ + "sql" + ], "privateLinkServiceConnectionState": { "status": "Approved", "description": "Auto-approved", diff --git a/specification/automation/resource-manager/Microsoft.Automation/preview/2020-01-13-preview/examples/PrivateEndpointConnectionListGet.json b/specification/automation/resource-manager/Microsoft.Automation/preview/2020-01-13-preview/examples/PrivateEndpointConnectionListGet.json index eb8cb7979e22..c42ab678ce6f 100644 --- a/specification/automation/resource-manager/Microsoft.Automation/preview/2020-01-13-preview/examples/PrivateEndpointConnectionListGet.json +++ b/specification/automation/resource-manager/Microsoft.Automation/preview/2020-01-13-preview/examples/PrivateEndpointConnectionListGet.json @@ -17,7 +17,9 @@ "privateEndpoint": { "id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/rg1Network/providers/Microsoft.Network/privateEndpoints/privateEndpointName" }, - "groupIds": ["sql"], + "groupIds": [ + "sql" + ], "privateLinkServiceConnectionState": { "status": "Approved", "description": "Auto-approved", @@ -33,7 +35,9 @@ "privateEndpoint": { "id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/rg1Network/providers/Microsoft.Network/privateEndpoints/privateEndpointName2" }, - "groupIds": ["sql"], + "groupIds": [ + "sql" + ], "privateLinkServiceConnectionState": { "status": "Approved", "description": "Auto-approved", diff --git a/specification/automation/resource-manager/Microsoft.Automation/preview/2020-01-13-preview/examples/PrivateEndpointConnectionUpdate.json b/specification/automation/resource-manager/Microsoft.Automation/preview/2020-01-13-preview/examples/PrivateEndpointConnectionUpdate.json index ad9078ea3c22..9228a535e791 100644 --- a/specification/automation/resource-manager/Microsoft.Automation/preview/2020-01-13-preview/examples/PrivateEndpointConnectionUpdate.json +++ b/specification/automation/resource-manager/Microsoft.Automation/preview/2020-01-13-preview/examples/PrivateEndpointConnectionUpdate.json @@ -24,7 +24,9 @@ "privateEndpoint": { "id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/rg1Network/providers/Microsoft.Network/privateEndpoints/privateEndpointName" }, - "groupIds": ["sql"], + "groupIds": [ + "sql" + ], "privateLinkServiceConnectionState": { "status": "Approved", "description": "Auto-approved", From 71d818c5f0a31c0549781252c2ac20c7af045685 Mon Sep 17 00:00:00 2001 From: Chenjie Shi Date: Wed, 20 Apr 2022 21:36:52 +0800 Subject: [PATCH 3/3] fix consistency problem with two swagger file --- .../Microsoft.Automation/stable/2019-06-01/schedule.json | 1 + 1 file changed, 1 insertion(+) diff --git a/specification/automation/resource-manager/Microsoft.Automation/stable/2019-06-01/schedule.json b/specification/automation/resource-manager/Microsoft.Automation/stable/2019-06-01/schedule.json index 42c67d859565..a007a956568c 100644 --- a/specification/automation/resource-manager/Microsoft.Automation/stable/2019-06-01/schedule.json +++ b/specification/automation/resource-manager/Microsoft.Automation/stable/2019-06-01/schedule.json @@ -338,6 +338,7 @@ "items": { "$ref": "#/definitions/AdvancedScheduleMonthlyOccurrence" }, + "x-ms-identifiers": [], "description": "Occurrences of days within a month." } },