From 16bd84bb1d2670379a4f8463057799cfb8728440 Mon Sep 17 00:00:00 2001 From: srikanthparatala Date: Wed, 24 Aug 2022 12:31:10 +0530 Subject: [PATCH 01/12] Added "tenantId" property to workspace response --- .../preview/2021-06-01-preview/examples/GetWorkspace.json | 3 ++- .../stable/2021-06-01/examples/GetWorkspace.json | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/examples/GetWorkspace.json b/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/examples/GetWorkspace.json index 13c82a2f8ce4..f86063115185 100644 --- a/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/examples/GetWorkspace.json +++ b/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/examples/GetWorkspace.json @@ -40,7 +40,8 @@ "projectName": "myProject", "repositoryName": "myRepository", "collaborationBranch": "master", - "rootFolder": "/" + "rootFolder": "/", + "tenantId": "00000000-0000-0000-0000-000000000000" }, "provisioningState": "Succeeded", "privateEndpointConnections": [ diff --git a/specification/synapse/resource-manager/Microsoft.Synapse/stable/2021-06-01/examples/GetWorkspace.json b/specification/synapse/resource-manager/Microsoft.Synapse/stable/2021-06-01/examples/GetWorkspace.json index e653c5ba1744..4fa806aae334 100644 --- a/specification/synapse/resource-manager/Microsoft.Synapse/stable/2021-06-01/examples/GetWorkspace.json +++ b/specification/synapse/resource-manager/Microsoft.Synapse/stable/2021-06-01/examples/GetWorkspace.json @@ -40,7 +40,8 @@ "projectName": "myProject", "repositoryName": "myRepository", "collaborationBranch": "master", - "rootFolder": "/" + "rootFolder": "/", + "tenantId": "00000000-0000-0000-0000-000000000000" }, "provisioningState": "Succeeded", "privateEndpointConnections": [ From a90b03447518af07c650828fb09429c6f8d98967 Mon Sep 17 00:00:00 2001 From: srikanthparatala Date: Fri, 2 Sep 2022 16:20:19 +0530 Subject: [PATCH 02/12] Fixed Model Validation errors --- .../examples/CreateOrUpdateWorkspace.json | 10 +++++----- .../2021-06-01-preview/examples/DeleteWorkspace.json | 3 +++ .../examples/DeleteWorkspaceAadAdmin.json | 6 +++++- .../2021-06-01-preview/examples/GetWorkspace.json | 2 +- .../examples/ListWorkspacesInSubscription.json | 4 ++-- .../2021-06-01-preview/examples/UpdateWorkspace.json | 4 ++-- .../preview/2021-06-01-preview/workspace.json | 8 ++++---- 7 files changed, 22 insertions(+), 15 deletions(-) diff --git a/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/examples/CreateOrUpdateWorkspace.json b/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/examples/CreateOrUpdateWorkspace.json index 57d7ae2744a8..89afa4fb8d50 100644 --- a/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/examples/CreateOrUpdateWorkspace.json +++ b/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/examples/CreateOrUpdateWorkspace.json @@ -77,8 +77,8 @@ "principalId": "eeeeeeee-9999-4444-8888-333333333333" } }, - "principalId": "f4b0f1c2-xxxx-43db-xxxx-ccd99e1afd22", - "tenantId": "72f988bf-xxxx-41af-xxxx-2d7cd011db47" + "principalId": "00000000-1111-2222-3333-444444444444", + "tenantId": "00000000-1111-2222-3333-444444444444" }, "properties": { "defaultDataLakeStorage": { @@ -121,7 +121,7 @@ } } ], - "workspaceUID": "999b999q-b888-4b44-bacd-2c222cc2222d", + "workspaceUID": "00000000-1111-2222-3333-444444444444", "encryption": { "doubleEncryptionEnabled": true, "cmk": { @@ -157,8 +157,8 @@ "principalId": "eeeeeeee-9999-4444-8888-333333333333" } }, - "principalId": "f4b0f1c2-xxxx-43db-xxxx-ccd99e1afd22", - "tenantId": "72f988bf-xxxx-41af-xxxx-2d7cd011db47" + "principalId": "00000000-1111-2222-3333-444444444444", + "tenantId": "00000000-1111-2222-3333-444444444444" }, "properties": { "defaultDataLakeStorage": { diff --git a/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/examples/DeleteWorkspace.json b/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/examples/DeleteWorkspace.json index 431ca71f1af0..add425666beb 100644 --- a/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/examples/DeleteWorkspace.json +++ b/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/examples/DeleteWorkspace.json @@ -7,6 +7,9 @@ }, "responses": { "202": { + "headers": { + "location": true + }, "body": { "id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/resourceGroup1/providers/Microsoft.Synapse/workspaces/workspace1", "name": "workspace1", diff --git a/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/examples/DeleteWorkspaceAadAdmin.json b/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/examples/DeleteWorkspaceAadAdmin.json index 6ed31af08176..79fbeb2bcb1d 100644 --- a/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/examples/DeleteWorkspaceAadAdmin.json +++ b/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/examples/DeleteWorkspaceAadAdmin.json @@ -8,7 +8,11 @@ "responses": { "200": {}, "204": {}, - "202": {}, + "202": { + "headers": { + "location": true + } + }, "default": { "body": { "error": { diff --git a/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/examples/GetWorkspace.json b/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/examples/GetWorkspace.json index f86063115185..51022e6d0cbf 100644 --- a/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/examples/GetWorkspace.json +++ b/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/examples/GetWorkspace.json @@ -62,7 +62,7 @@ } } ], - "workspaceUID": "999b999q-b888-4b44-bacd-2c222cc2222d", + "workspaceUID": "00000000-1111-2222-3333-444444444444", "cspWorkspaceAdminProperties": { "initialWorkspaceAdminObjectId": "6c20646f-8050-49ec-b3b1-80a0e58e454d" }, diff --git a/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/examples/ListWorkspacesInSubscription.json b/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/examples/ListWorkspacesInSubscription.json index e2a3217bfcf8..a69029ad52b0 100644 --- a/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/examples/ListWorkspacesInSubscription.json +++ b/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/examples/ListWorkspacesInSubscription.json @@ -24,7 +24,7 @@ "sqlAdministratorLogin": "login", "managedResourceGroupName": "resourceGroup2", "provisioningState": "Succeeded", - "workspaceUID": "999b999q-b888-4b44-bacd-2c222cc2222d" + "workspaceUID": "00000000-1111-2222-3333-444444444444" }, "tags": { "key": "value" @@ -47,7 +47,7 @@ "sqlAdministratorLogin": "login", "managedResourceGroupName": "resourceGroup2", "provisioningState": "Succeeded", - "workspaceUID": "999b999q-b888-4b44-bacd-2c222cc2222d" + "workspaceUID": "00000000-1111-2222-3333-444444444444" }, "tags": { "key": "value" diff --git a/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/examples/UpdateWorkspace.json b/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/examples/UpdateWorkspace.json index 6f9c17c5b25c..cf7232eba2c1 100644 --- a/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/examples/UpdateWorkspace.json +++ b/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/examples/UpdateWorkspace.json @@ -73,7 +73,7 @@ "sqlAdministratorLogin": "login", "managedResourceGroupName": "resourceGroup2", "provisioningState": "Succeeded", - "workspaceUID": "999b999q-b888-4b44-bacd-2c222cc2222d", + "workspaceUID": "00000000-1111-2222-3333-444444444444", "encryption": { "doubleEncryptionEnabled": true, "cmk": { @@ -119,7 +119,7 @@ "sqlAdministratorLogin": "login", "managedResourceGroupName": "resourceGroup2", "provisioningState": "Provisioning", - "workspaceUID": "999b999q-b888-4b44-bacd-2c222cc2222d", + "workspaceUID": "00000000-1111-2222-3333-444444444444", "encryption": { "doubleEncryptionEnabled": true, "cmk": { diff --git a/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/workspace.json b/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/workspace.json index c9f615abb39b..9ffdb98d4cde 100644 --- a/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/workspace.json +++ b/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/workspace.json @@ -270,18 +270,18 @@ "responses": { "200": { "schema": { - "type": "object" + "$ref": "#/definitions/Workspace" }, "description": "OK" }, "202": { "schema": { - "type": "object" + "$ref": "#/definitions/Workspace" }, - "description": "" + "description": "Accepted" }, "204": { - "description": "" + "description": "No Content" }, "default": { "schema": { From 6cb2b0ba0139170973df26baf1a77e3ecd91ac5f Mon Sep 17 00:00:00 2001 From: srikanthparatala Date: Mon, 12 Sep 2022 09:56:26 +0530 Subject: [PATCH 03/12] Fix Model validation format uuid errors --- .../stable/2021-06-01/examples/CreateOrUpdateWorkspace.json | 6 +++--- .../stable/2021-06-01/examples/GetWorkspace.json | 2 +- .../2021-06-01/examples/ListWorkspacesInSubscription.json | 4 ++-- .../stable/2021-06-01/examples/UpdateWorkspace.json | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/specification/synapse/resource-manager/Microsoft.Synapse/stable/2021-06-01/examples/CreateOrUpdateWorkspace.json b/specification/synapse/resource-manager/Microsoft.Synapse/stable/2021-06-01/examples/CreateOrUpdateWorkspace.json index 52018eda6acf..9c4f060191d2 100644 --- a/specification/synapse/resource-manager/Microsoft.Synapse/stable/2021-06-01/examples/CreateOrUpdateWorkspace.json +++ b/specification/synapse/resource-manager/Microsoft.Synapse/stable/2021-06-01/examples/CreateOrUpdateWorkspace.json @@ -78,7 +78,7 @@ } }, "principalId": "f4b0f1c2-xxxx-43db-xxxx-ccd99e1afd22", - "tenantId": "72f988bf-xxxx-41af-xxxx-2d7cd011db47" + "tenantId": "00000000-1111-2222-3333-444444444444" }, "properties": { "defaultDataLakeStorage": { @@ -121,7 +121,7 @@ } } ], - "workspaceUID": "999b999q-b888-4b44-bacd-2c222cc2222d", + "workspaceUID": "00000000-1111-2222-3333-444444444444", "encryption": { "doubleEncryptionEnabled": true, "cmk": { @@ -158,7 +158,7 @@ } }, "principalId": "f4b0f1c2-xxxx-43db-xxxx-ccd99e1afd22", - "tenantId": "72f988bf-xxxx-41af-xxxx-2d7cd011db47" + "tenantId": "00000000-1111-2222-3333-444444444444" }, "properties": { "defaultDataLakeStorage": { diff --git a/specification/synapse/resource-manager/Microsoft.Synapse/stable/2021-06-01/examples/GetWorkspace.json b/specification/synapse/resource-manager/Microsoft.Synapse/stable/2021-06-01/examples/GetWorkspace.json index 4fa806aae334..b0a049ece305 100644 --- a/specification/synapse/resource-manager/Microsoft.Synapse/stable/2021-06-01/examples/GetWorkspace.json +++ b/specification/synapse/resource-manager/Microsoft.Synapse/stable/2021-06-01/examples/GetWorkspace.json @@ -62,7 +62,7 @@ } } ], - "workspaceUID": "999b999q-b888-4b44-bacd-2c222cc2222d", + "workspaceUID": "00000000-1111-2222-3333-444444444444", "cspWorkspaceAdminProperties": { "initialWorkspaceAdminObjectId": "6c20646f-8050-49ec-b3b1-80a0e58e454d" }, diff --git a/specification/synapse/resource-manager/Microsoft.Synapse/stable/2021-06-01/examples/ListWorkspacesInSubscription.json b/specification/synapse/resource-manager/Microsoft.Synapse/stable/2021-06-01/examples/ListWorkspacesInSubscription.json index f97e3f522eda..9e1daddb05ad 100644 --- a/specification/synapse/resource-manager/Microsoft.Synapse/stable/2021-06-01/examples/ListWorkspacesInSubscription.json +++ b/specification/synapse/resource-manager/Microsoft.Synapse/stable/2021-06-01/examples/ListWorkspacesInSubscription.json @@ -24,7 +24,7 @@ "sqlAdministratorLogin": "login", "managedResourceGroupName": "resourceGroup2", "provisioningState": "Succeeded", - "workspaceUID": "999b999q-b888-4b44-bacd-2c222cc2222d" + "workspaceUID": "00000000-1111-2222-3333-444444444444" }, "tags": { "key": "value" @@ -47,7 +47,7 @@ "sqlAdministratorLogin": "login", "managedResourceGroupName": "resourceGroup2", "provisioningState": "Succeeded", - "workspaceUID": "999b999q-b888-4b44-bacd-2c222cc2222d" + "workspaceUID": "00000000-1111-2222-3333-444444444444" }, "tags": { "key": "value" diff --git a/specification/synapse/resource-manager/Microsoft.Synapse/stable/2021-06-01/examples/UpdateWorkspace.json b/specification/synapse/resource-manager/Microsoft.Synapse/stable/2021-06-01/examples/UpdateWorkspace.json index 3dac82d06f23..59868379758e 100644 --- a/specification/synapse/resource-manager/Microsoft.Synapse/stable/2021-06-01/examples/UpdateWorkspace.json +++ b/specification/synapse/resource-manager/Microsoft.Synapse/stable/2021-06-01/examples/UpdateWorkspace.json @@ -73,7 +73,7 @@ "sqlAdministratorLogin": "login", "managedResourceGroupName": "resourceGroup2", "provisioningState": "Succeeded", - "workspaceUID": "999b999q-b888-4b44-bacd-2c222cc2222d", + "workspaceUID": "00000000-1111-2222-3333-444444444444", "encryption": { "doubleEncryptionEnabled": true, "cmk": { @@ -119,7 +119,7 @@ "sqlAdministratorLogin": "login", "managedResourceGroupName": "resourceGroup2", "provisioningState": "Provisioning", - "workspaceUID": "999b999q-b888-4b44-bacd-2c222cc2222d", + "workspaceUID": "00000000-1111-2222-3333-444444444444", "encryption": { "doubleEncryptionEnabled": true, "cmk": { From add2ea31d3a7743cf3c2b6be2f12e18cb14d3043 Mon Sep 17 00:00:00 2001 From: srikanthparatala Date: Wed, 14 Sep 2022 06:59:29 +0530 Subject: [PATCH 04/12] Fixed lint errors --- .../stable/2021-06-01/examples/DeleteWorkspace.json | 3 +++ .../stable/2021-06-01/examples/DeleteWorkspaceAadAdmin.json | 6 +++++- .../Microsoft.Synapse/stable/2021-06-01/workspace.json | 4 ++-- 3 files changed, 10 insertions(+), 3 deletions(-) diff --git a/specification/synapse/resource-manager/Microsoft.Synapse/stable/2021-06-01/examples/DeleteWorkspace.json b/specification/synapse/resource-manager/Microsoft.Synapse/stable/2021-06-01/examples/DeleteWorkspace.json index 7647c496c457..71f60a6739fb 100644 --- a/specification/synapse/resource-manager/Microsoft.Synapse/stable/2021-06-01/examples/DeleteWorkspace.json +++ b/specification/synapse/resource-manager/Microsoft.Synapse/stable/2021-06-01/examples/DeleteWorkspace.json @@ -7,6 +7,9 @@ }, "responses": { "202": { + "headers": { + "location": true + }, "body": { "id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/resourceGroup1/providers/Microsoft.Synapse/workspaces/workspace1", "name": "workspace1", diff --git a/specification/synapse/resource-manager/Microsoft.Synapse/stable/2021-06-01/examples/DeleteWorkspaceAadAdmin.json b/specification/synapse/resource-manager/Microsoft.Synapse/stable/2021-06-01/examples/DeleteWorkspaceAadAdmin.json index fc24927279b6..048921309471 100644 --- a/specification/synapse/resource-manager/Microsoft.Synapse/stable/2021-06-01/examples/DeleteWorkspaceAadAdmin.json +++ b/specification/synapse/resource-manager/Microsoft.Synapse/stable/2021-06-01/examples/DeleteWorkspaceAadAdmin.json @@ -8,7 +8,11 @@ "responses": { "200": {}, "204": {}, - "202": {}, + "202": { + "headers": { + "location": true + } + }, "default": { "body": { "error": { diff --git a/specification/synapse/resource-manager/Microsoft.Synapse/stable/2021-06-01/workspace.json b/specification/synapse/resource-manager/Microsoft.Synapse/stable/2021-06-01/workspace.json index 51965b7cbd20..fce11a36d8e1 100644 --- a/specification/synapse/resource-manager/Microsoft.Synapse/stable/2021-06-01/workspace.json +++ b/specification/synapse/resource-manager/Microsoft.Synapse/stable/2021-06-01/workspace.json @@ -270,13 +270,13 @@ "responses": { "200": { "schema": { - "type": "object" + "$ref": "#/definitions/Workspace" }, "description": "OK" }, "202": { "schema": { - "type": "object" + "$ref": "#/definitions/Workspace" }, "description": "" }, From 2ac27492aed84a43f4d5039f1922209211d8c1e6 Mon Sep 17 00:00:00 2001 From: srikanthparatala Date: Wed, 14 Sep 2022 11:41:38 +0530 Subject: [PATCH 05/12] Fix model validation error Expected type but found type object, Expected type string but found type object --- .../preview/2021-06-01-preview/workspace.json | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/workspace.json b/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/workspace.json index 91297e85ef8e..7ea90ca37a0a 100644 --- a/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/workspace.json +++ b/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/workspace.json @@ -1689,6 +1689,7 @@ } ], "properties": { + "type": "object", "properties": { "title": "Trusted Service By Pass Configuration properties", "description": "Trusted Service By Pass Configuration properties", @@ -1816,11 +1817,11 @@ "description": "The max ECO tokens per pool" }, "extendedProperties": { - "type": "string", + "type": "object", "description": "Scope Pool Extended Properties", "properties": { "poolLimitAndPolicies": { - "type": "string", + "type": "object", "description": "Scope pool Limit And Policies", "properties": { "maxTokensPerJob": { From 4d85f1d1af02d74a59af7228dc94ed45483bf6a7 Mon Sep 17 00:00:00 2001 From: srikanthparatala Date: Wed, 14 Sep 2022 11:55:10 +0530 Subject: [PATCH 06/12] Fix semantic validation error Expected type object but found type string --- .../Microsoft.Synapse/preview/2021-06-01-preview/workspace.json | 1 - 1 file changed, 1 deletion(-) diff --git a/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/workspace.json b/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/workspace.json index 7ea90ca37a0a..a952f767ee9f 100644 --- a/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/workspace.json +++ b/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/workspace.json @@ -1689,7 +1689,6 @@ } ], "properties": { - "type": "object", "properties": { "title": "Trusted Service By Pass Configuration properties", "description": "Trusted Service By Pass Configuration properties", From f3b67384368310f3125b19d3b8ca1b650bcb3591 Mon Sep 17 00:00:00 2001 From: srikanthparatala Date: Wed, 14 Sep 2022 14:54:59 +0530 Subject: [PATCH 07/12] Fix Model validation error --- .../preview/2021-06-01-preview/workspace.json | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/workspace.json b/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/workspace.json index a952f767ee9f..9854819407cf 100644 --- a/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/workspace.json +++ b/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/workspace.json @@ -898,7 +898,7 @@ }, { "schema": { - "type": "object", + "type": "array", "items": { "$ref": "#/definitions/TrustedServiceByPassConfiguration" } @@ -912,7 +912,7 @@ "responses": { "200": { "schema": { - "type": "object", + "type": "array", "items": { "$ref": "#/definitions/TrustedServiceByPassConfiguration" } @@ -958,7 +958,7 @@ }, { "schema": { - "type": "object", + "type": "array", "items": { "$ref": "#/definitions/CheckDefaultStorageAccountStatus" } @@ -972,7 +972,7 @@ "responses": { "200": { "schema": { - "type": "object", + "type": "array", "items": { "$ref": "#/definitions/CheckDefaultStorageAccountStatus" } From 2116c37b4e48b6bbfadaa0b002bc3b577022c3d0 Mon Sep 17 00:00:00 2001 From: srikanthparatala Date: Wed, 14 Sep 2022 15:03:00 +0530 Subject: [PATCH 08/12] Revert "Fix Model validation error" This reverts commit f3b67384368310f3125b19d3b8ca1b650bcb3591. --- .../preview/2021-06-01-preview/workspace.json | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/workspace.json b/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/workspace.json index 9854819407cf..a952f767ee9f 100644 --- a/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/workspace.json +++ b/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/workspace.json @@ -898,7 +898,7 @@ }, { "schema": { - "type": "array", + "type": "object", "items": { "$ref": "#/definitions/TrustedServiceByPassConfiguration" } @@ -912,7 +912,7 @@ "responses": { "200": { "schema": { - "type": "array", + "type": "object", "items": { "$ref": "#/definitions/TrustedServiceByPassConfiguration" } @@ -958,7 +958,7 @@ }, { "schema": { - "type": "array", + "type": "object", "items": { "$ref": "#/definitions/CheckDefaultStorageAccountStatus" } @@ -972,7 +972,7 @@ "responses": { "200": { "schema": { - "type": "array", + "type": "object", "items": { "$ref": "#/definitions/CheckDefaultStorageAccountStatus" } From 12b67c32292f3930f7a6347d8cb3fd0b4e15f947 Mon Sep 17 00:00:00 2001 From: srikanthparatala Date: Wed, 14 Sep 2022 15:03:40 +0530 Subject: [PATCH 09/12] Fix Modelvalidation error --- .../preview/2021-06-01-preview/workspace.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/workspace.json b/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/workspace.json index a952f767ee9f..80a73dc2cd35 100644 --- a/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/workspace.json +++ b/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/workspace.json @@ -912,7 +912,7 @@ "responses": { "200": { "schema": { - "type": "object", + "type": "array", "items": { "$ref": "#/definitions/TrustedServiceByPassConfiguration" } @@ -972,7 +972,7 @@ "responses": { "200": { "schema": { - "type": "object", + "type": "array", "items": { "$ref": "#/definitions/CheckDefaultStorageAccountStatus" } From d5c48de49b7d10ef75124c4caeff8596bb79082c Mon Sep 17 00:00:00 2001 From: srikanthparatala Date: Thu, 15 Sep 2022 13:11:40 +0530 Subject: [PATCH 10/12] Changed location to string Resolved review comments --- .../preview/2021-06-01-preview/examples/DeleteWorkspace.json | 2 +- .../stable/2021-06-01/examples/DeleteWorkspaceAadAdmin.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/examples/DeleteWorkspace.json b/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/examples/DeleteWorkspace.json index add425666beb..2826d9e52966 100644 --- a/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/examples/DeleteWorkspace.json +++ b/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/examples/DeleteWorkspace.json @@ -8,7 +8,7 @@ "responses": { "202": { "headers": { - "location": true + "location": "" }, "body": { "id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/resourceGroup1/providers/Microsoft.Synapse/workspaces/workspace1", diff --git a/specification/synapse/resource-manager/Microsoft.Synapse/stable/2021-06-01/examples/DeleteWorkspaceAadAdmin.json b/specification/synapse/resource-manager/Microsoft.Synapse/stable/2021-06-01/examples/DeleteWorkspaceAadAdmin.json index 048921309471..44139ee7e719 100644 --- a/specification/synapse/resource-manager/Microsoft.Synapse/stable/2021-06-01/examples/DeleteWorkspaceAadAdmin.json +++ b/specification/synapse/resource-manager/Microsoft.Synapse/stable/2021-06-01/examples/DeleteWorkspaceAadAdmin.json @@ -10,7 +10,7 @@ "204": {}, "202": { "headers": { - "location": true + "location": "" } }, "default": { From f67def18782b56b49d683654aa0f5358a6e9dd52 Mon Sep 17 00:00:00 2001 From: srikanthparatala Date: Thu, 15 Sep 2022 13:12:18 +0530 Subject: [PATCH 11/12] Resolved review comments --- .../2021-06-01-preview/examples/DeleteWorkspaceAadAdmin.json | 2 +- .../stable/2021-06-01/examples/DeleteWorkspace.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/examples/DeleteWorkspaceAadAdmin.json b/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/examples/DeleteWorkspaceAadAdmin.json index 79fbeb2bcb1d..bef8ffd5cfc4 100644 --- a/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/examples/DeleteWorkspaceAadAdmin.json +++ b/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/examples/DeleteWorkspaceAadAdmin.json @@ -10,7 +10,7 @@ "204": {}, "202": { "headers": { - "location": true + "location": "" } }, "default": { diff --git a/specification/synapse/resource-manager/Microsoft.Synapse/stable/2021-06-01/examples/DeleteWorkspace.json b/specification/synapse/resource-manager/Microsoft.Synapse/stable/2021-06-01/examples/DeleteWorkspace.json index 71f60a6739fb..68f76386c6af 100644 --- a/specification/synapse/resource-manager/Microsoft.Synapse/stable/2021-06-01/examples/DeleteWorkspace.json +++ b/specification/synapse/resource-manager/Microsoft.Synapse/stable/2021-06-01/examples/DeleteWorkspace.json @@ -8,7 +8,7 @@ "responses": { "202": { "headers": { - "location": true + "location": "" }, "body": { "id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/resourceGroup1/providers/Microsoft.Synapse/workspaces/workspace1", From 1fd05ed80cef09e5bcae095dbf144446c6a36a2a Mon Sep 17 00:00:00 2001 From: srikanthparatala Date: Thu, 15 Sep 2022 13:41:09 +0530 Subject: [PATCH 12/12] Resolve LRO location error --- .../preview/2021-06-01-preview/examples/DeleteWorkspace.json | 2 +- .../2021-06-01-preview/examples/DeleteWorkspaceAadAdmin.json | 2 +- .../stable/2021-06-01/examples/DeleteWorkspace.json | 2 +- .../stable/2021-06-01/examples/DeleteWorkspaceAadAdmin.json | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/examples/DeleteWorkspace.json b/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/examples/DeleteWorkspace.json index 2826d9e52966..b5b2d141c037 100644 --- a/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/examples/DeleteWorkspace.json +++ b/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/examples/DeleteWorkspace.json @@ -8,7 +8,7 @@ "responses": { "202": { "headers": { - "location": "" + "azure-asyncoperation": "https://ms.web.azuresynapse.net" }, "body": { "id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/resourceGroup1/providers/Microsoft.Synapse/workspaces/workspace1", diff --git a/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/examples/DeleteWorkspaceAadAdmin.json b/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/examples/DeleteWorkspaceAadAdmin.json index bef8ffd5cfc4..87db24da9c61 100644 --- a/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/examples/DeleteWorkspaceAadAdmin.json +++ b/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/examples/DeleteWorkspaceAadAdmin.json @@ -10,7 +10,7 @@ "204": {}, "202": { "headers": { - "location": "" + "azure-asyncoperation": "https://ms.web.azuresynapse.net" } }, "default": { diff --git a/specification/synapse/resource-manager/Microsoft.Synapse/stable/2021-06-01/examples/DeleteWorkspace.json b/specification/synapse/resource-manager/Microsoft.Synapse/stable/2021-06-01/examples/DeleteWorkspace.json index 68f76386c6af..539652049dc3 100644 --- a/specification/synapse/resource-manager/Microsoft.Synapse/stable/2021-06-01/examples/DeleteWorkspace.json +++ b/specification/synapse/resource-manager/Microsoft.Synapse/stable/2021-06-01/examples/DeleteWorkspace.json @@ -8,7 +8,7 @@ "responses": { "202": { "headers": { - "location": "" + "azure-asyncoperation": "https://ms.web.azuresynapse.net" }, "body": { "id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/resourceGroup1/providers/Microsoft.Synapse/workspaces/workspace1", diff --git a/specification/synapse/resource-manager/Microsoft.Synapse/stable/2021-06-01/examples/DeleteWorkspaceAadAdmin.json b/specification/synapse/resource-manager/Microsoft.Synapse/stable/2021-06-01/examples/DeleteWorkspaceAadAdmin.json index 44139ee7e719..8aa3473e736c 100644 --- a/specification/synapse/resource-manager/Microsoft.Synapse/stable/2021-06-01/examples/DeleteWorkspaceAadAdmin.json +++ b/specification/synapse/resource-manager/Microsoft.Synapse/stable/2021-06-01/examples/DeleteWorkspaceAadAdmin.json @@ -10,7 +10,7 @@ "204": {}, "202": { "headers": { - "location": "" + "azure-asyncoperation": "https://ms.web.azuresynapse.net" } }, "default": {