From 00037d0d234cda9f024092433bc23fac60e25b10 Mon Sep 17 00:00:00 2001 From: Teddy Todorov Date: Wed, 27 Sep 2023 13:07:54 -0700 Subject: [PATCH 1/3] Capacity Reservation Groups is not an async resource, and thus does not have 202 as a response type --- .../examples/CapacityReservationGroup/delete.json | 1 - .../preview/2023-08-01-preview/mfe.json | 3 --- 2 files changed, 4 deletions(-) diff --git a/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-08-01-preview/examples/CapacityReservationGroup/delete.json b/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-08-01-preview/examples/CapacityReservationGroup/delete.json index 99e9ffd9388e..fcf39250653f 100644 --- a/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-08-01-preview/examples/CapacityReservationGroup/delete.json +++ b/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-08-01-preview/examples/CapacityReservationGroup/delete.json @@ -7,7 +7,6 @@ }, "responses": { "200": {}, - "202": {}, "204": {} } } diff --git a/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-08-01-preview/mfe.json b/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-08-01-preview/mfe.json index e665a8645b57..faf6c4bf8d4c 100644 --- a/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-08-01-preview/mfe.json +++ b/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-08-01-preview/mfe.json @@ -131,9 +131,6 @@ "200": { "description": "Success" }, - "202": { - "description": "Accepted" - }, "204": { "description": "No Content" }, From 76b817b2040e6b55e04d5b3abb6e65b02687aef1 Mon Sep 17 00:00:00 2001 From: Teddy Todorov Date: Wed, 27 Sep 2023 13:10:35 -0700 Subject: [PATCH 2/3] PATCH response must have same resource as GET/PUT APIs --- .../CapacityReservationGroup/update.json | 45 ++++++++++++++++++- .../preview/2023-08-01-preview/mfe.json | 5 ++- 2 files changed, 48 insertions(+), 2 deletions(-) diff --git a/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-08-01-preview/examples/CapacityReservationGroup/update.json b/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-08-01-preview/examples/CapacityReservationGroup/update.json index 8f0defa1a87d..f33bfbef6e07 100644 --- a/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-08-01-preview/examples/CapacityReservationGroup/update.json +++ b/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-08-01-preview/examples/CapacityReservationGroup/update.json @@ -22,6 +22,49 @@ } }, "responses": { - "200": {} + "200": { + "headers": {}, + "body": { + "id": "string", + "name": "string", + "type": "string", + "properties": { + "offer": { + "publisher": "string", + "offerName": "string" + }, + "reservedCapacity": 1 + }, + "systemData": { + "createdAt": "2020-01-01T12:34:56.999+00:15", + "createdBy": "string", + "createdByType": "User", + "lastModifiedAt": "2020-01-01T12:34:56.999+00:15", + "lastModifiedBy": "string", + "lastModifiedByType": "ManagedIdentity" + }, + "tags": {}, + "location": "string", + "kind": "string", + "identity": { + "type": "SystemAssigned", + "principalId": "00000000-1111-2222-3333-444444444444", + "tenantId": "00000000-1111-2222-3333-444444444444", + "userAssignedIdentities": { + "string": { + "principalId": "00000000-1111-2222-3333-444444444444", + "clientId": "00000000-1111-2222-3333-444444444444" + } + } + }, + "sku": { + "name": "string", + "tier": "Premium", + "size": "string", + "family": "string", + "capacity": 1 + } + } + } } } diff --git a/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-08-01-preview/mfe.json b/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-08-01-preview/mfe.json index faf6c4bf8d4c..589a147d396f 100644 --- a/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-08-01-preview/mfe.json +++ b/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-08-01-preview/mfe.json @@ -232,7 +232,10 @@ ], "responses": { "200": { - "description": "Success" + "description": "Success", + "schema": { + "$ref": "#/definitions/CapacityReservationGroupTrackedResource" + } }, "default": { "description": "Error", From f40cd894deedf72f795d75832fed38b199178ac9 Mon Sep 17 00:00:00 2001 From: Teddy Todorov Date: Wed, 27 Sep 2023 13:13:06 -0700 Subject: [PATCH 3/3] add missing description --- .../preview/2023-08-01-preview/mfe.json | 1 + 1 file changed, 1 insertion(+) diff --git a/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-08-01-preview/mfe.json b/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-08-01-preview/mfe.json index 589a147d396f..fec7bba79374 100644 --- a/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-08-01-preview/mfe.json +++ b/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-08-01-preview/mfe.json @@ -25134,6 +25134,7 @@ "type": "object", "properties": { "metrics": { + "description": "The model-specific metrics from the backing inference endpoint.", "type": "object", "additionalProperties": { "type": "string",