Add Support for Changed Spec Identification in spec-gen-sdk-runner tool #32763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raych1
requested review from
weshaggard,
mikeharder and
benbp
as code owners
Next Steps to MergeNext steps that must be taken to merge this PR:
|
|
PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment. |
openapi-pipeline-app
bot
added
PipelineBotTrigger
and removed
PipelineBotTrigger
labels
openapi-pipeline-app
bot
added
PipelineBotTrigger
and removed
PipelineBotTrigger
labels
openapi-pipeline-app
bot
added
PipelineBotTrigger
and removed
PipelineBotTrigger
labels
weshaggard
reviewed
Feb 25, 2025
| * @param options - Search configuration options | ||
| * @returns Object mapping project directory paths to arrays of related shared library files | ||
| */ | ||
| export function searchRelatedTypeSpecProjectBySharedLibrary( |
There was a problem hiding this comment.
Just as an FYI if we end up taking on Jeff directory structure changes there will not be a notion of a shared library.
There was a problem hiding this comment.
That's right. Regardless of the final version of the new folder layout, our tools will need to be updated to support the changes. This version is to support the current folder layout.
weshaggard
approved these changes
Feb 25, 2025
naveedaz
pushed a commit
that referenced
this pull request
Feb 26, 2025
* Bump @azure-tools/typespec-client-generator-core (#32797) Bumps the typespec group with 1 update in the / directory: [@azure-tools/typespec-client-generator-core](https://github.com/Azure/typespec-azure). Updates `@azure-tools/typespec-client-generator-core` from 0.51.2 to 0.51.3 - [Release notes](https://github.com/Azure/typespec-azure/releases) - [Commits](https://github.com/Azure/typespec-azure/compare/@azure-tools/[email protected]...@azure-tools/[email protected]) --- updated-dependencies: - dependency-name: "@azure-tools/typespec-client-generator-core" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: typespec ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Sync eng/common directory with azure-sdk-tools for PR 9902 (#32794) * populate triggeringPaths of each artifactdetails with the owning ci.yml * handle service-directory changes in Get-PrPkgProperties --------- Co-authored-by: Scott Beddall <[email protected]> * [keyvault] Update readme.python.md (#32530) * update oracle linked service (#32750) Co-authored-by: Jingshu918 <[email protected]> * Add Go Data Plane Rules of tspconfig.yaml for TSV (#32779) * manually add * add go dp rules * update --------- Co-authored-by: albertxavier100 <[email protected]> * Update Swagger for New PolicyDefinitions and PolicyTokens API (#32306) * Copy files from stable/2025-01-01 Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec. * Update version to stable/2025-03-01 Updated the API version from stable/2025-01-01 to stable/2025-03-01. * Added tag for 2025-03-01 in readme file * Update readme.md * Add external evaluation enforcement settings contract * Add policy token API contract * Swagger PrettierCheck * Swagger PrettierCheck * Fix JsonSerializationException * Update contract * Swagger LintDiff * Increment to v6 * Revert "Increment to v6" This reverts commit 64631c5. * Update error response * Update duration * Update sdk-suppressions.yaml --------- Co-authored-by: Celina Zhao <[email protected]> Co-authored-by: kazrael2119 <[email protected]> * [Key Vault] docs.microsoft.com -> learn.microsoft.com (#32769) * Add Support for Changed Spec Identification in spec-gen-sdk-runner tool (#32763) * Increase timeout for generation job * Added git op to the wrapper tool * cleaned all files before generation * updated specGenCommand for multiple generation * Used file system access for file search * Combined tsp and readme for same service * Update readme.python.md (#32838) * Update tspconfig.yaml (#32839) * migration accessment, config java sdk (#32840) * Update tspconfig.yaml (#32823) update name of sdk packaging * Update MixedReality API with deprecation message (#32386) * Update MixedReality API * Copy existing API versino spec files * Update new API * Update README with new API version * Add deprecation message for old API versions --------- Co-authored-by: Bianca Tazlauanu <[email protected]> * Add `ListConnectionsInGroup` Api (#31398) * Copy files from stable/2024-01-01 Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec. * Update version to stable/2024-12-01 Updated the API version from stable/2024-01-01 to stable/2024-12-01. * Added tag for 2024-12-01 in readme file * Update API spec and examples to 2024-12-01 * fix pagination according to https://github.com/Azure/azure-api-style-guide/blob/main/openapi-style-guide.md#support-for-pagination * fix(azurearcdata): remove arm-id from sqlServerDatabases (#32825) * fix(azurearcdata): remove arm-id from sqlServerDatabases * SRP 2024-01-01 API Version Swagger - PV2 date-time properties fix (#32835) * Code needs to handle more than one template library (#32853) Co-authored-by: James Suplizio <[email protected]> * Bump @autorest/openapi-to-typespec (#32834) Bumps the openapi-to-typespec group with 1 update in the / directory: [@autorest/openapi-to-typespec](https://github.com/Azure/autorest). Updates `@autorest/openapi-to-typespec` from 0.10.10 to 0.10.11 - [Release notes](https://github.com/Azure/autorest/releases) - [Commits](https://github.com/Azure/autorest/commits) --- updated-dependencies: - dependency-name: "@autorest/openapi-to-typespec" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: openapi-to-typespec ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Dev/mibreset/ccm exports fabric3 (#32444) * Copy files from stable/2024-08-01 Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec. * Update version to preview/2024-10-01-preview Updated the API version from stable/2024-08-01 to preview/2024-10-01-preview. * Added tag for 2024-10-01-preview in readme file * ran prettier on entire directory * made the changes for the fabric version * fixed spelling issue in pricesheet.json * adding 'destination type' as required since Destination is required and needs a required field * Fixed messed up date/time format * Fixed readme file, was missing the list of input files. * Removed required annotation from exportDeliveryDestination. * Include SystemAssigned,UserAssigned (#32826) * [EngSys] npm update (#32857) --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Scott Beddall <[email protected]> Co-authored-by: Yuchao Yan <[email protected]> Co-authored-by: Yao Kou <[email protected]> Co-authored-by: Jingshu918 <[email protected]> Co-authored-by: Wanpeng Li <[email protected]> Co-authored-by: albertxavier100 <[email protected]> Co-authored-by: ccz77 <[email protected]> Co-authored-by: Celina Zhao <[email protected]> Co-authored-by: kazrael2119 <[email protected]> Co-authored-by: McCoy Patiño <[email protected]> Co-authored-by: Ray Chen <[email protected]> Co-authored-by: ChenxiJiang333 <[email protected]> Co-authored-by: Weidong Xu <[email protected]> Co-authored-by: Aditya <[email protected]> Co-authored-by: Bianca Tazlauanu <[email protected]> Co-authored-by: Bianca Tazlauanu <[email protected]> Co-authored-by: yzt <[email protected]> Co-authored-by: Sean Wells <[email protected]> Co-authored-by: Mayuri-Gadsing <[email protected]> Co-authored-by: James Suplizio <[email protected]> Co-authored-by: Micah Bresette <[email protected]> Co-authored-by: nasc17 <[email protected]> Co-authored-by: Mike Harder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major changes are to identify the changed specs to pass into the
spec-gen-sdktool for SDK generation.[
eng/pipelines/templates/stages/archetype-spec-gen-sdk.yml]Updated the
parameterssection to includeUse1ESOfficial: falseand increased the job timeout to 2400 minutes.[
eng/tools/spec-gen-sdk-runner/src/change-files.ts]Introduced a new function
detectChangedSpecConfigFilesto detect changed specification configuration files in a pull request. This function identifies relatedreadme.mdandtspconfig.yamlfiles and logs the changes.[
eng/tools/spec-gen-sdk-runner/src/commands.ts]Added a new function
generateSdkForSpecPrto generate SDKs for specification pull requests.[
eng/tools/spec-gen-sdk-runner/src/utils.ts]Added a new utility function
resetGitRepoto reset unstaged changes in a git repository.@weshaggard can you review these changes?