Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add userAssignedIdentities #3283

Merged
merged 4 commits into from
Jul 9, 2018
Merged

Add userAssignedIdentities #3283

merged 4 commits into from
Jul 9, 2018

Conversation

chidmdxx
Copy link
Member

@chidmdxx chidmdxx commented Jun 21, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Jun 21, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2771

@AutorestCI
Copy link

AutorestCI commented Jun 21, 2018

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3023

@AutorestCI
Copy link

AutorestCI commented Jun 21, 2018

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2194

@AutorestCI
Copy link

AutorestCI commented Jun 21, 2018

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Jun 21, 2018

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2202

@annatisch
Copy link
Member

Thanks @chidmdxx! The changes in the PR look good.

However this spec has a large number of ARM violations in the linter CI. They are all unrelated to the change in this PR however they should be addressed. A large number of them could easily be resolved with some improved descriptions or adding examples. Others could be resolved by applying for suppression until a longer term fix can be implemented.
https://travis-ci.org/Azure/azure-rest-api-specs/jobs/394813179

Would it be possible to address any of these?

@annatisch
Copy link
Member

ping @chidmdxx

@chidmdxx
Copy link
Member Author

chidmdxx commented Jul 2, 2018

@annatisch sorry missed the notification, how can we apply for a temporal suppression, we've been trying to get these down via a team effort instead of one person PR

@annatisch
Copy link
Member

Thanks @chidmdxx - please contact @ravbhatnagar to apply for suppressions. :)

@@ -2952,6 +2952,11 @@
"name": "ResourceIdentityType",
"modelAsString": false
}
},
"userAssignedIdentities":{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This object has a defined shape correct? Can we add the complete schema for this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no defined shape
it's a dictionary where keys are the resource ids and the value is an empty jobject

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the example file as discussed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have something similar to what compute did

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Customer s will have hard time using the SDK without having a shape defined for such fields

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @anuchandy was having a hard time with how to shape the swagger property

@ravbhatnagar
Copy link
Contributor

Discussed offline. Added an example for the shape of the object.

@ravbhatnagar ravbhatnagar added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Jul 3, 2018
@ravbhatnagar
Copy link
Contributor

@annatisch @chidmdxx - If the violations are something we will fix, there is no suppression process. We are tracking towards fixing these. This should not block the PR.

@annatisch
Copy link
Member

@chidmdxx - could you please let me know you intentions regarding the remaining violations? If you intend to fix them in subsequent PRs I will go ahead and merge this one.

@chidmdxx
Copy link
Member Author

chidmdxx commented Jul 9, 2018

@annatisch as @ravbhatnagar mentioned we are tracking in ARM to fix the violation is subsequent PRs

@annatisch annatisch merged commit 662a332 into Azure:master Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants