-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SRP 2024-01-01 API Version Swagger - PV2 date-time properties fix #32835
Merged
+18
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
Generated ApiView
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
This was referenced Feb 26, 2025
/azp run |
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
blueww
approved these changes
Feb 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks good to me.
This PR is for a swagger fix to be aligned with server behavior.
- Server actually returne following 3 properties in RFC1123 format,
- Swagger define them as "date-time" which is RFC 3339.
- So current swagger is not aligned with server behavior and will cause some SDK generated from swagger fail to parse server responds.
- We have validated after changing the format to "date-time-rfc1123", all SDK/PSH/CLI works.
Following is copied from network trace from server responds.
"nextAllowedQuotaDowngradeTime": "Mon, 24 Feb 2025 07:42:22 GMT",
"nextAllowedProvisionedIopsDowngradeTime": "Mon, 24 Feb 2025 07:42:22 GMT",
"nextAllowedProvisionedBandwidthDowngradeTime": "Mon, 24 Feb 2025 07:42:22 GMT",
naveedaz
pushed a commit
that referenced
this pull request
Feb 26, 2025
* Bump @azure-tools/typespec-client-generator-core (#32797) Bumps the typespec group with 1 update in the / directory: [@azure-tools/typespec-client-generator-core](https://github.com/Azure/typespec-azure). Updates `@azure-tools/typespec-client-generator-core` from 0.51.2 to 0.51.3 - [Release notes](https://github.com/Azure/typespec-azure/releases) - [Commits](https://github.com/Azure/typespec-azure/compare/@azure-tools/[email protected]...@azure-tools/[email protected]) --- updated-dependencies: - dependency-name: "@azure-tools/typespec-client-generator-core" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: typespec ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Sync eng/common directory with azure-sdk-tools for PR 9902 (#32794) * populate triggeringPaths of each artifactdetails with the owning ci.yml * handle service-directory changes in Get-PrPkgProperties --------- Co-authored-by: Scott Beddall <[email protected]> * [keyvault] Update readme.python.md (#32530) * update oracle linked service (#32750) Co-authored-by: Jingshu918 <[email protected]> * Add Go Data Plane Rules of tspconfig.yaml for TSV (#32779) * manually add * add go dp rules * update --------- Co-authored-by: albertxavier100 <[email protected]> * Update Swagger for New PolicyDefinitions and PolicyTokens API (#32306) * Copy files from stable/2025-01-01 Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec. * Update version to stable/2025-03-01 Updated the API version from stable/2025-01-01 to stable/2025-03-01. * Added tag for 2025-03-01 in readme file * Update readme.md * Add external evaluation enforcement settings contract * Add policy token API contract * Swagger PrettierCheck * Swagger PrettierCheck * Fix JsonSerializationException * Update contract * Swagger LintDiff * Increment to v6 * Revert "Increment to v6" This reverts commit 64631c5. * Update error response * Update duration * Update sdk-suppressions.yaml --------- Co-authored-by: Celina Zhao <[email protected]> Co-authored-by: kazrael2119 <[email protected]> * [Key Vault] docs.microsoft.com -> learn.microsoft.com (#32769) * Add Support for Changed Spec Identification in spec-gen-sdk-runner tool (#32763) * Increase timeout for generation job * Added git op to the wrapper tool * cleaned all files before generation * updated specGenCommand for multiple generation * Used file system access for file search * Combined tsp and readme for same service * Update readme.python.md (#32838) * Update tspconfig.yaml (#32839) * migration accessment, config java sdk (#32840) * Update tspconfig.yaml (#32823) update name of sdk packaging * Update MixedReality API with deprecation message (#32386) * Update MixedReality API * Copy existing API versino spec files * Update new API * Update README with new API version * Add deprecation message for old API versions --------- Co-authored-by: Bianca Tazlauanu <[email protected]> * Add `ListConnectionsInGroup` Api (#31398) * Copy files from stable/2024-01-01 Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec. * Update version to stable/2024-12-01 Updated the API version from stable/2024-01-01 to stable/2024-12-01. * Added tag for 2024-12-01 in readme file * Update API spec and examples to 2024-12-01 * fix pagination according to https://github.com/Azure/azure-api-style-guide/blob/main/openapi-style-guide.md#support-for-pagination * fix(azurearcdata): remove arm-id from sqlServerDatabases (#32825) * fix(azurearcdata): remove arm-id from sqlServerDatabases * SRP 2024-01-01 API Version Swagger - PV2 date-time properties fix (#32835) * Code needs to handle more than one template library (#32853) Co-authored-by: James Suplizio <[email protected]> * Bump @autorest/openapi-to-typespec (#32834) Bumps the openapi-to-typespec group with 1 update in the / directory: [@autorest/openapi-to-typespec](https://github.com/Azure/autorest). Updates `@autorest/openapi-to-typespec` from 0.10.10 to 0.10.11 - [Release notes](https://github.com/Azure/autorest/releases) - [Commits](https://github.com/Azure/autorest/commits) --- updated-dependencies: - dependency-name: "@autorest/openapi-to-typespec" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: openapi-to-typespec ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Dev/mibreset/ccm exports fabric3 (#32444) * Copy files from stable/2024-08-01 Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec. * Update version to preview/2024-10-01-preview Updated the API version from stable/2024-08-01 to preview/2024-10-01-preview. * Added tag for 2024-10-01-preview in readme file * ran prettier on entire directory * made the changes for the fabric version * fixed spelling issue in pricesheet.json * adding 'destination type' as required since Destination is required and needs a required field * Fixed messed up date/time format * Fixed readme file, was missing the list of input files. * Removed required annotation from exportDeliveryDestination. * Include SystemAssigned,UserAssigned (#32826) * [EngSys] npm update (#32857) --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Scott Beddall <[email protected]> Co-authored-by: Yuchao Yan <[email protected]> Co-authored-by: Yao Kou <[email protected]> Co-authored-by: Jingshu918 <[email protected]> Co-authored-by: Wanpeng Li <[email protected]> Co-authored-by: albertxavier100 <[email protected]> Co-authored-by: ccz77 <[email protected]> Co-authored-by: Celina Zhao <[email protected]> Co-authored-by: kazrael2119 <[email protected]> Co-authored-by: McCoy Patiño <[email protected]> Co-authored-by: Ray Chen <[email protected]> Co-authored-by: ChenxiJiang333 <[email protected]> Co-authored-by: Weidong Xu <[email protected]> Co-authored-by: Aditya <[email protected]> Co-authored-by: Bianca Tazlauanu <[email protected]> Co-authored-by: Bianca Tazlauanu <[email protected]> Co-authored-by: yzt <[email protected]> Co-authored-by: Sean Wells <[email protected]> Co-authored-by: Mayuri-Gadsing <[email protected]> Co-authored-by: James Suplizio <[email protected]> Co-authored-by: Micah Bresette <[email protected]> Co-authored-by: nasc17 <[email protected]> Co-authored-by: Mike Harder <[email protected]>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ARMReview
ARMSignedOff
<valid label in PR review process>add this label when ARM approve updates after review
BreakingChange-Approved-BugFix
Changes are to correct the REST API definition to correctly describe service behavior
BreakingChangeReviewRequired
<valid label in PR review process>add this label when breaking change review is required
brownfield
Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec.
PipelineBotTrigger
PublishToCustomers
Acknowledgement the changes will be published to Azure customers.
ReadyForApiTest
<valid label in PR review process>add this label when swagger and service APIs are ready for test
resource-manager
Storage
Storage Service (Queues, Blobs, Files)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting help
section at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PR
andDue diligence checklist
.write access
per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.