Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cognitive Services] Stop override LUIS client class names, revert a case change in CustomVision. #3368

Merged
merged 2 commits into from Jul 9, 2018

Conversation

yangyuan
Copy link
Member

@yangyuan yangyuan commented Jul 6, 2018

  1. Client class names, addition to [Cognitive Services] unify client class names, folder cases. #3365
  2. Revert a case change in CustomVision, (XUnit HttpMockServer is case sensitive)

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Jul 6, 2018

Automation for azure-sdk-for-python

This PR contains more than 3 context, SDK generation is not enabled. Contexts found:

  • cognitiveservices/data-plane/LUIS/Runtime
  • cognitiveservices/data-plane/CustomVision/Prediction
  • cognitiveservices/data-plane/CustomVision/Training
  • cognitiveservices/data-plane/LUIS/Authoring

@AutorestCI
Copy link

AutorestCI commented Jul 6, 2018

Automation for azure-sdk-for-node

This PR contains more than 3 context, SDK generation is not enabled. Contexts found:

  • cognitiveservices/data-plane/LUIS/Authoring
  • cognitiveservices/data-plane/CustomVision/Training
  • cognitiveservices/data-plane/CustomVision/Prediction
  • cognitiveservices/data-plane/LUIS/Runtime

@AutorestCI
Copy link

AutorestCI commented Jul 6, 2018

Automation for azure-sdk-for-java

This PR contains more than 3 context, SDK generation is not enabled. Contexts found:

  • cognitiveservices/data-plane/LUIS/Authoring
  • cognitiveservices/data-plane/CustomVision/Training
  • cognitiveservices/data-plane/LUIS/Runtime
  • cognitiveservices/data-plane/CustomVision/Prediction

@AutorestCI
Copy link

AutorestCI commented Jul 6, 2018

Automation for azure-sdk-for-ruby

This PR contains more than 3 context, SDK generation is not enabled. Contexts found:

  • cognitiveservices/data-plane/LUIS/Runtime
  • cognitiveservices/data-plane/CustomVision/Training
  • cognitiveservices/data-plane/CustomVision/Prediction
  • cognitiveservices/data-plane/LUIS/Authoring

@AutorestCI
Copy link

AutorestCI commented Jul 6, 2018

Automation for azure-sdk-for-go

This PR contains more than 3 context, SDK generation is not enabled. Contexts found:

  • cognitiveservices/data-plane/CustomVision/Prediction
  • cognitiveservices/data-plane/LUIS/Runtime
  • cognitiveservices/data-plane/LUIS/Authoring
  • cognitiveservices/data-plane/CustomVision/Training

@yangyuan yangyuan changed the title [Cognitive Services] Stop override LUIS client class names. [Cognitive Services] Stop override LUIS client class names, revert a case change in CustomVision. Jul 6, 2018
Copy link
Member

@marstr marstr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised that we have case-sensitive paths in Azure. This seems like a real smell to me. However, I'm not going to stand in the way when I'm being told that this is in the way of people being able to use the service.

@marstr marstr merged commit 9c7c5ee into Azure:master Jul 9, 2018
@yangyuan
Copy link
Member Author

yangyuan commented Jul 9, 2018

@marstr
About the case sensitive stuff, actually both works.
But the testing framework is case-sensitive in URL. Will work with corresponding team to solve the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants