Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MetricAlert swagger fix #3602

Closed
wants to merge 3 commits into from
Closed

MetricAlert swagger fix #3602

wants to merge 3 commits into from

Conversation

hovsepm
Copy link
Contributor

@hovsepm hovsepm commented Aug 7, 2018

Since enum types were not declared as type=string generation on C# and Java side (checked in Fluent code) was producing object types instead of Enums or ExpandableStringEnum.

@hovsepm hovsepm added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Aug 7, 2018
@azuresdkci azuresdkci requested a review from jhendrixMSFT August 7, 2018 22:41
@AutorestCI
Copy link

AutorestCI commented Aug 7, 2018

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#2761

@AutorestCI
Copy link

AutorestCI commented Aug 7, 2018

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Aug 7, 2018

Automation for azure-sdk-for-node

A PR has been created for you:
Azure/azure-sdk-for-node#3306

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@hovsepm
Copy link
Contributor Author

hovsepm commented Aug 7, 2018

@jhendrixMSFT waiting for the owner team sign-off.

@AutorestCI
Copy link

AutorestCI commented Aug 7, 2018

Automation for azure-sdk-for-java

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-java#2139

@AutorestCI
Copy link

AutorestCI commented Aug 7, 2018

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#2631

@jhendrixMSFT
Copy link
Member

@hovsepm are we still waiting on the owner to review?

@hovsepm
Copy link
Contributor Author

hovsepm commented Aug 10, 2018

@jhendrixMSFT yes we do. They are kind of slow.

@jhendrixMSFT
Copy link
Member

@hovsepm Any update? Do we need to tag somebody for the review?

@hovsepm
Copy link
Contributor Author

hovsepm commented Aug 17, 2018

@jhendrixMSFT I sent them couple of emails already. Please reassign it to me if you are ok with the changes (I was aware about breaking change issue that is why am waiting for the owner team to take actions).

@jhendrixMSFT
Copy link
Member

@hovsepm The changes LGTM, but yeah I'll reassign to you since you're working with the owning team.

@jhendrixMSFT jhendrixMSFT assigned hovsepm and unassigned jhendrixMSFT Aug 17, 2018
@hovsepm
Copy link
Contributor Author

hovsepm commented Sep 6, 2018

Closing due to 0 response from owner team.

@hovsepm hovsepm closed this Sep 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DoNotMerge <valid label in PR review process> use to hold merge after approval potential-sdk-breaking-change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants