-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[App Insights/Operational Insights] Add GET /query operation, fix operationId inconsistency #3771
Conversation
Automation for azure-sdk-for-rubyNothing to generate for azure-sdk-for-ruby |
Automation for azure-sdk-for-pythonA PR has been created for you: |
Automation for azure-sdk-for-nodeA PR has been created for you: |
Automation for azure-sdk-for-javaNothing to generate for azure-sdk-for-java |
Automation for azure-sdk-for-goA PR has been created for you: |
Can one of the admins verify this patch? |
@@ -88,7 +88,7 @@ | |||
} | |||
}, | |||
"post": { | |||
"operationId": "Query", | |||
"operationId": "Query_Execute", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes in stable API are potential SDK breaking changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had been doing work to clean up the operation groups as part of a general effort towards stable/ v1.0.0 versions of the data plane SDKs (we have preview versions for C#, Node, Java, and Python). This isn't strictly necessary and I could revert it, but is in line with what I've done in the other api-versions/with App Insights as well.
@alexeldeib please, resolve this issue https://travis-ci.org/Azure/azure-rest-api-specs/jobs/422715930 |
@sergey-shandar I fixed a few issues, OAV is failing to validate this line in the spec however, which I haven't changed in months: https://travis-ci.org/Azure/azure-rest-api-specs/jobs/423166594#L651 Line 1081 in e850b4e
I think this is an issue with OAV though? The property is clearly defined, even if the validation can't see it. Could it be an issue parsing the @ in the key? |
@alexeldeib yes, it's OAV issue. I will check if I can fix it. |
@alexeldeib I will provide a fix for OAV to unblock the PR. |
@alexeldeib I've fixed the semantic validation tool, it works now https://travis-ci.org/Azure/azure-rest-api-specs/builds/423166589?utm_source=github_status&utm_medium=notification There are still model validation issues https://travis-ci.org/Azure/azure-rest-api-specs/jobs/423166602 |
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-version
in the path should match theapi-version
in the spec).Quality of Swagger