Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[App Insights/Operational Insights] Add GET /query operation, fix operationId inconsistency #3771

Merged
merged 4 commits into from
Sep 11, 2018

Conversation

alexeldeib
Copy link
Contributor

@alexeldeib alexeldeib commented Aug 30, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Aug 30, 2018

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Aug 30, 2018

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#3234

@alexeldeib alexeldeib changed the title [AppInsights/OperationalInsights] Add GET equivalent of existing POST for completeness; fix operationId inconsistency [App Insights/Operational Insights] Add GET /query operation, fix operationId inconsistency Aug 30, 2018
@AutorestCI
Copy link

AutorestCI commented Aug 30, 2018

Automation for azure-sdk-for-node

A PR has been created for you:
Azure/azure-sdk-for-node#3466

@AutorestCI
Copy link

AutorestCI commented Aug 30, 2018

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI
Copy link

AutorestCI commented Aug 30, 2018

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#2669

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@@ -88,7 +88,7 @@
}
},
"post": {
"operationId": "Query",
"operationId": "Query_Execute",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in stable API are potential SDK breaking changes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had been doing work to clean up the operation groups as part of a general effort towards stable/ v1.0.0 versions of the data plane SDKs (we have preview versions for C#, Node, Java, and Python). This isn't strictly necessary and I could revert it, but is in line with what I've done in the other api-versions/with App Insights as well.

@sergey-shandar
Copy link
Contributor

@alexeldeib please, resolve this issue https://travis-ci.org/Azure/azure-rest-api-specs/jobs/422715930

@alexeldeib
Copy link
Contributor Author

alexeldeib commented Aug 31, 2018

@sergey-shandar I fixed a few issues, OAV is failing to validate this line in the spec however, which I haven't changed in months:

https://travis-ci.org/Azure/azure-rest-api-specs/jobs/423166594#L651

I think this is an issue with OAV though? The property is clearly defined, even if the validation can't see it. Could it be an issue parsing the @ in the key?

@sergey-shandar
Copy link
Contributor

@alexeldeib yes, it's OAV issue. I will check if I can fix it.

@sergey-shandar
Copy link
Contributor

@alexeldeib I will provide a fix for OAV to unblock the PR.

@sergey-shandar
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants