Fix Swagger Linting Error for Microsoft.Features

[zjpjack]

Fix Swagger Linting Error for Microsoft.Features

[AutorestCI]

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3187

[azuresdkci]

Can one of the admins verify this patch?

[annatisch]

Thanks @zjpjack - your new examples have a couple of model validation errors - could you take a look?

 error: 
operationId: ListOperations
scenario: List Features operations
source: response
responseCode: '200'
severity: 0
errorCode: OBJECT_ADDITIONAL_PROPERTIES
errorDetails:
  code: OBJECT_ADDITIONAL_PROPERTIES
  params:
    - - properties
  message: 'Additional properties not allowed: properties'
  path: value/0/display
  title: /definitions/generated.nested.definitions.Operation.properties.display
  description: The object that represents the operation.
  similarPaths:
    - value/1/display
  position:
    line: 286
    column: 20
  url: >-
    specification/resources/resource-manager/Microsoft.Features/stable/2015-12-01/features.json
  jsonPosition:
    line: 12
    column: 36
  jsonUrl: >-
    specification/resources/resource-manager/Microsoft.Features/stable/2015-12-01/examples/listFeaturesOperations.json

 error: 
operationId: Features_Get
scenario: Get feature
source: response
responseCode: '200'
severity: 0
errorCode: OBJECT_ADDITIONAL_PROPERTIES
errorDetails:
  code: OBJECT_ADDITIONAL_PROPERTIES
  params:
    - - type
      - id
      - properties
      - name
  message: 'Additional properties not allowed: type,id,properties,name'
  path: properties
  title: /definitions/FeatureProperties
  description: Information about feature.
  position:
    line: 232
    column: 26
  url: >-
    specification/resources/resource-manager/Microsoft.Features/stable/2015-12-01/features.json
  jsonPosition:
    line: 13
    column: 21
  jsonUrl: >-
    specification/resources/resource-manager/Microsoft.Features/stable/2015-12-01/examples/getFeature.json

 error: 
operationId: Features_Register
scenario: Register feature
source: response
responseCode: '200'
severity: 0
errorCode: OBJECT_ADDITIONAL_PROPERTIES
errorDetails:
  code: OBJECT_ADDITIONAL_PROPERTIES
  params:
    - - type
      - id
      - properties
      - name
  message: 'Additional properties not allowed: type,id,properties,name'
  path: properties
  title: /definitions/FeatureProperties
  description: Information about feature.
  position:
    line: 232
    column: 26
  url: >-
    specification/resources/resource-manager/Microsoft.Features/stable/2015-12-01/features.json
  jsonPosition:
    line: 13
    column: 21
  jsonUrl: >-
    specification/resources/resource-manager/Microsoft.Features/stable/2015-12-01/examples/registerFeature.json

[zjpjack]

@annatisch Can I check these model validation on my local machine?

[annatisch]

I believe so - you need to set up the npm environment (specifically the oav package).
This is the script we run:
https://github.com/Azure/azure-rest-api-specs/blob/master/scripts/modelValidation.js

[zjpjack]

@annatisch The new iteration should be good

[annatisch]

Should this be an enum of specific values?

[zjpjack]

Usually, the operation type only has read, write, delete and action.

[AutorestCI]

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

[AutorestCI]

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#2758

[AutorestCI]

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2194

[AutorestCI]

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3643

[annatisch]

ping @zjpjack - did you have any comments on my review feedback?

[zjpjack]

@annatisch I replied you last Friday, maybe you didn't notice. I am waiting for your response. Thanks

[annatisch]

Thanks @zjpjack - I'm confused - you responded to my question about enums? In email or here - I can't see it :)

[zjpjack]

@annatisch please choose "File changes" tab. Your comments are in there, and I also reply u there

[annatisch]

@zjpjack - weird - I can't see any reply to my comments in the file changes either... Maybe you could just paste your responses here in the main conversation?

[zjpjack]

@annatisch Now you should see them :)

[AutorestCI]

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js