Fix ARMViolations for Microsoft.Resources #3912

zjpjack · 2018-09-14T22:33:41Z

Fix ARMViolations for Microsoft.Resources

AutorestCI · 2018-09-14T22:35:18Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3187

AutorestCI · 2018-09-14T22:35:39Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2018-09-14T22:37:01Z

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3692

azuresdkci · 2018-09-14T22:37:50Z

Can one of the admins verify this patch?

zjpjack · 2018-09-14T22:39:19Z

specification/resources/resource-manager/Microsoft.Resources/stable/2018-05-01/resources.json

@@ -34,6 +34,31 @@
    }


In this file, when we use autorest to check ARM violations, we always have ARMViolations for "TagDetails". The error is that we must have name and type properties for it, and "TagDetails" has extra properties ['tagName', 'count', 'values']. I checked resources.json for 2018-02-01, the definition for "TagDetails" is the same, but there is no such errors in autorest. Do you know how I can address it?

Hi @zjpjack
Please add a suppression rule for the TagDetails object in the Readme. You can tag example on the compute file, this should look like this:

directive: - where: - $.definitions.TagDetails suppress: - NameOfYourErrorInCamelCase

I will let @ravbhatnagar knows this suppression, he or I will send another PR for these suppression rules.

AutorestCI · 2018-09-14T22:39:55Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2818

AutorestCI · 2018-09-14T22:39:59Z

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2194

zjpjack · 2018-09-19T17:56:54Z

@lmazuel Can you please take a look? Thanks

lmazuel · 2018-09-19T19:52:19Z

Hi @zjpjack somehow I missed your PR in my notification, which is unusual :(. Taking a look right now.

...fication/resources/resource-manager/Microsoft.Resources/stable/2016-06-01/subscriptions.json

specification/resources/resource-manager/Microsoft.Resources/stable/2016-09-01/links.json

specification/resources/resource-manager/Microsoft.Resources/stable/2018-05-01/resources.json

lmazuel · 2018-09-19T20:49:43Z

specification/resources/resource-manager/Microsoft.Resources/stable/2018-05-01/resources.json

          "type": "string",
          "description": "The name of the deployment."
        },
+        "type": {


I just checked the CLI recording that is supposed to return this object:
https://github.com/Azure/azure-cli/blob/dev/src/command_modules/azure-cli-resource/azure/cli/command_modules/resource/tests/latest/recordings/test_subscription_level_deployment.yaml#L66-L68

There is no "type" in the JSON. Could you give me more context why you think it's necessary?

According to Autorest, if there is no "type", then we get the following error
ERROR (RequiredPropertiesMissingInResourceModel/R2020/ARMViolation): Model definition 'DeploymentExtended' must have the properties 'name', 'id' and 'type' in its hierarchy and these properties must be marked as readonly.
Any suggestion for this?

The most important is that the Swagger represent the absolute truth about the server. This is indeed an ARM violation, the linter is right that this call does not respect ARM.
Correct to handle this is to send an email to @ravbhatnagar to describe the issue and ask for a ARM suppression rule. So at least the non-conformance is known and documented. Adding type here just shut off the alarm and doesn't solve anything.

I will let @ravbhatnagar knows this suppression, he or I will send another PR for these suppression rules.

lmazuel · 2018-09-19T20:54:03Z

specification/resources/resource-manager/Microsoft.Resources/stable/2018-05-01/resources.json

@@ -34,6 +34,31 @@
    }


Hi @zjpjack
Please add a suppression rule for the TagDetails object in the Readme. You can tag example on the compute file, this should look like this:

directive: - where: - $.definitions.TagDetails suppress: - NameOfYourErrorInCamelCase

specification/resources/resource-manager/Microsoft.Resources/stable/2016-09-01/links.json

specification/resources/resource-manager/Microsoft.Resources/stable/2018-05-01/resources.json

...fication/resources/resource-manager/Microsoft.Resources/stable/2016-06-01/subscriptions.json

specification/resources/resource-manager/Microsoft.Resources/stable/2016-09-01/links.json

specification/resources/resource-manager/Microsoft.Resources/stable/2018-05-01/resources.json

…into msft-jizen/resources_violations

zjpjack · 2018-09-24T18:58:13Z

@lmazuel Replied your comments. Can you please take a look?

lmazuel · 2018-09-24T23:53:29Z

@zjpjack Added comments. Thanks!

zjpjack · 2018-09-25T00:01:30Z

@lmazuel For those comments about missing discription for display, I already had them in this PR, it is just below the display

...fication/resources/resource-manager/Microsoft.Resources/stable/2016-06-01/subscriptions.json

AutorestCI · 2018-09-25T20:18:57Z

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

Fix ARMViolations for Microsoft.Resources

2677dee

AutorestCI mentioned this pull request Sep 14, 2018

[AutoPR resources/resource-manager] Fix ARMViolations for Microsoft.Resources Azure/azure-sdk-for-python#3356

Merged

AutorestCI mentioned this pull request Sep 14, 2018

[AutoPR resources/resource-manager] Fix ARMViolations for Microsoft.Resources Azure/azure-sdk-for-node#3611

Merged

zjpjack commented Sep 14, 2018

View reviewed changes

AutorestCI mentioned this pull request Sep 14, 2018

[AutoPR resources/resource-manager] Fix ARMViolations for Microsoft.Resources Azure/azure-sdk-for-go#2702

Closed

AutorestCI mentioned this pull request Sep 14, 2018

[AutoPR resources/resource-manager] Fix ARMViolations for Microsoft.Resources Azure/azure-sdk-for-java#2395

Merged

azuresdkci assigned lmazuel Sep 14, 2018

azuresdkci requested a review from lmazuel September 14, 2018 22:45

lmazuel requested changes Sep 19, 2018

View reviewed changes

lmazuel reviewed Sep 19, 2018

View reviewed changes

...fication/resources/resource-manager/Microsoft.Resources/stable/2016-06-01/subscriptions.json Show resolved Hide resolved

lmazuel reviewed Sep 19, 2018

View reviewed changes

specification/resources/resource-manager/Microsoft.Resources/stable/2016-09-01/links.json Show resolved Hide resolved

lmazuel reviewed Sep 19, 2018

View reviewed changes

specification/resources/resource-manager/Microsoft.Resources/stable/2018-05-01/resources.json Show resolved Hide resolved

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs …

a6b4f32

…into msft-jizen/resources_violations

zjpjack commented Sep 25, 2018

View reviewed changes

...fication/resources/resource-manager/Microsoft.Resources/stable/2016-06-01/subscriptions.json Show resolved Hide resolved

Fix ARM Violations in Microsoft.Resources

d1873c4

AutorestCI mentioned this pull request Sep 25, 2018

[AutoPR resources/resource-manager] Fix ARMViolations for Microsoft.Resources Azure/azure-sdk-for-go#2817

Merged

lmazuel approved these changes Sep 25, 2018

View reviewed changes

lmazuel merged commit 793d150 into Azure:master Sep 25, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix ARMViolations for Microsoft.Resources #3912

Fix ARMViolations for Microsoft.Resources #3912

zjpjack commented Sep 14, 2018

AutorestCI commented Sep 14, 2018 •

edited

Loading

AutorestCI commented Sep 14, 2018 •

edited

Loading

AutorestCI commented Sep 14, 2018 •

edited

Loading

azuresdkci commented Sep 14, 2018

zjpjack Sep 14, 2018

lmazuel Sep 19, 2018

zjpjack Sep 25, 2018

AutorestCI commented Sep 14, 2018 •

edited

Loading

AutorestCI commented Sep 14, 2018 •

edited

Loading

zjpjack commented Sep 19, 2018

lmazuel commented Sep 19, 2018

lmazuel Sep 19, 2018

zjpjack Sep 24, 2018

lmazuel Sep 24, 2018

zjpjack Sep 25, 2018

lmazuel Sep 19, 2018

zjpjack commented Sep 24, 2018

lmazuel commented Sep 24, 2018

zjpjack commented Sep 25, 2018

AutorestCI commented Sep 25, 2018 •

edited

Loading

Fix ARMViolations for Microsoft.Resources #3912

Fix ARMViolations for Microsoft.Resources #3912

Conversation

zjpjack commented Sep 14, 2018

AutorestCI commented Sep 14, 2018 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Sep 14, 2018 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Sep 14, 2018 • edited Loading

Automation for azure-sdk-for-node

azuresdkci commented Sep 14, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AutorestCI commented Sep 14, 2018 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Sep 14, 2018 • edited Loading

Automation for azure-sdk-for-java

zjpjack commented Sep 19, 2018

lmazuel commented Sep 19, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zjpjack commented Sep 24, 2018

lmazuel commented Sep 24, 2018

zjpjack commented Sep 25, 2018

AutorestCI commented Sep 25, 2018 • edited Loading

Automation for azure-sdk-for-js

AutorestCI commented Sep 14, 2018 •

edited

Loading

AutorestCI commented Sep 14, 2018 •

edited

Loading

AutorestCI commented Sep 14, 2018 •

edited

Loading

AutorestCI commented Sep 14, 2018 •

edited

Loading

AutorestCI commented Sep 14, 2018 •

edited

Loading

AutorestCI commented Sep 25, 2018 •

edited

Loading