Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change operationId of Microsoft.Authorization #3969

Merged
merged 1 commit into from
Sep 20, 2018
Merged

Change operationId of Microsoft.Authorization #3969

merged 1 commit into from
Sep 20, 2018

Conversation

zjpjack
Copy link
Contributor

@zjpjack zjpjack commented Sep 20, 2018

Change operationId of Microsoft.Authorization

@azuresdkci azuresdkci requested a review from dsgouda September 20, 2018 17:57
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI AutorestCI mentioned this pull request Sep 20, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Sep 20, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3187

dsgouda
dsgouda approved these changes Sep 20, 2018
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AutorestCI
Copy link

AutorestCI commented Sep 20, 2018 •
edited
Loading

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

@dsgouda dsgouda merged commit 57cc3b1 into Azure:master Sep 20, 2018
@zjpjack
Copy link
Contributor Author

zjpjack commented Sep 20, 2018

Hi @dsgouda Just wonder why this is potential-sdk-breaking-change?

@dsgouda
Copy link
Contributor

dsgouda commented Sep 20, 2018

If an SDK has been published and a user is already making a call on the ListOperations method, they won't find it anymore

@AutorestCI AutorestCI mentioned this pull request Sep 20, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Sep 20, 2018 •
edited
Loading

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

@AutorestCI AutorestCI mentioned this pull request Sep 20, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Sep 20, 2018 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2778

@AutorestCI
Copy link

AutorestCI commented Sep 20, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI AutorestCI mentioned this pull request Sep 20, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Sep 20, 2018 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsgouda dsgouda dsgouda approved these changes

Assignees

@dsgouda dsgouda

Labels
potential-sdk-breaking-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zjpjack @azuresdkci @AutorestCI @dsgouda