Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[App Insights] Fix string modeling for enum, package naming #3997

Merged
merged 4 commits into from
Sep 28, 2018
Merged

[App Insights] Fix string modeling for enum, package naming #3997

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b081d89
modelAsString for enum...
alexeldeib Sep 23, 2018
2cba8d2
sync definition and parameter
alexeldeib Sep 23, 2018
2902fb3
update c# namespace
alexeldeib Sep 24, 2018
2b80686
remove double directive:
alexeldeib Sep 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions specification/applicationinsights/data-plane/microsoft.insights/preview/v1/AppInsights.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,7 +459,7 @@
],
"x-ms-enum": {
"name": "MetricsAggregation",
"modelAsString": false
"modelAsString": true
}
}
},
Expand Down Expand Up @@ -744,7 +744,7 @@
],
"x-ms-enum": {
"name": "MetricsAggregation",
"modelAsString": false
"modelAsString": true
}
}
},
Expand Down
16 changes: 9 additions & 7 deletions specification/applicationinsights/data-plane/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,9 @@ input-file:
directive:
- reason: Don't expose the GET endpoint since it's behavior is more limited than POST
remove-operation: Query_Get
- from: swagger-document
where: $.definitions.table.properties.rows.items.items.type
transform: $ = "object"
```

``` yaml $(tag) == '20180420'
Expand All @@ -49,6 +52,9 @@ input-file:
directive:
- reason: Don't expose the GET endpoint since it's behavior is more limited than POST
remove-operation: Query_Get
- from: swagger-document
where: $.definitions.table.properties.rows.items.items.type
transform: $ = "object"
```

# Code Generation
Expand All @@ -71,23 +77,19 @@ Please also specify `--csharp-sdks-folder=<path to "SDKs" directory of your azur
``` yaml $(csharp)
csharp:
license-header: MICROSOFT_MIT_NO_VERSION
namespace: Microsoft.Azure.ApplicationInsights
namespace: Microsoft.Azure.ApplicationInsights.Query
output-folder: $(csharp-sdks-folder)/ApplicationInsights/DataPlane/ApplicationInsights/Generated
clear-output-folder: true
payload-flattening-threshold: 3
directive:
- from: swagger-document
where: $.definitions.table.properties.rows.items.items.type
transform: $ = "object"
```

``` yaml $(python)
python-mode: create
python:
license-header: MICROSOFT_MIT_NO_VERSION
payload-flattening-threshold: 2
namespace: azure.applicationinsights
package-name: azure-applicationinsights
namespace: azure.applicationinsights.query
package-name: azure-applicationinsights-query
package-version: 0.1.0
directive:
- from: swagger-document
Expand Down