Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customvision v2.2 #4162

Merged
merged 4 commits into from
Oct 17, 2018
Merged

Customvision v2.2 #4162

merged 4 commits into from
Oct 17, 2018

Conversation

areddish
Copy link
Contributor

Updates for Custom Vision version 2.2

@areddish areddish requested a review from yangyuan as a code owner October 10, 2018 23:47
@AutorestCI
Copy link

AutorestCI commented Oct 10, 2018 •
edited
Loading

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

@AutorestCI
Copy link

AutorestCI commented Oct 10, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI AutorestCI mentioned this pull request Oct 10, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Oct 10, 2018 •
edited
Loading

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#3549

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI AutorestCI mentioned this pull request Oct 11, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Oct 11, 2018 •
edited
Loading

Automation for azure-sdk-for-java

A PR has been created for you:
Azure/azure-sdk-for-java#2522

@azuresdkci azuresdkci requested a review from annatisch October 11, 2018 00:10
@AutorestCI
Copy link

AutorestCI commented Oct 11, 2018 •
edited
Loading

Automation for azure-sdk-for-node

A PR has been created for you:
Azure/azure-sdk-for-node#3812

@AutorestCI AutorestCI mentioned this pull request Oct 11, 2018
Closed
@annatisch annatisch added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 15, 2018
@annatisch
Copy link
Member

Adding @ravbhatnagar to review new API version.

KrisBash
KrisBash approved these changes Oct 15, 2018
View reviewed changes
Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signing off from ARM

@KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 15, 2018
@annatisch
Copy link
Member

Hi @areddish - Just making sure that you're aware that this PR includes major breaking changes that will result in major version bumps for published SDKs - is this your intention?

annatisch
annatisch approved these changes Oct 15, 2018
View reviewed changes
Copy link
Member

@annatisch annatisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @areddish - the changes generally look good, although this spec is missing lots of documentation. I've left comments by some of them but descriptions are missing throughout.

specification/cognitiveservices/data-plane/CustomVision/Training/stable/v2.2/Training.json
"name": "projectId",
"in": "path",
"description": "The id of the project to get",
"re
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add "description" to "images" and "tagIds".

@areddish
Copy link
Contributor Author

@annatisch Yes, this is intended to be a breaking change that will result in a major version change.

I'll look into adding more descriptions

@AutorestCI
Copy link

AutorestCI commented Oct 16, 2018 •
edited
Loading

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#3041

@AutorestCI AutorestCI mentioned this pull request Oct 16, 2018
Merged
@annatisch annatisch merged commit 8e7c7fe into Azure:master Oct 17, 2018
@areddish areddish mentioned this pull request Oct 18, 2018
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KrisBash KrisBash KrisBash approved these changes

@yangyuan yangyuan yangyuan approved these changes

@annatisch annatisch annatisch approved these changes

Assignees

@annatisch annatisch

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review potential-sdk-breaking-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@areddish @AutorestCI @azuresdkci @annatisch @KrisBash @yangyuan