Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in source code win_http_transport.cpp #3443

Closed
Jinming-Hu opened this issue Mar 17, 2022 · 0 comments · Fixed by #3583
Closed

Typo in source code win_http_transport.cpp #3443

Jinming-Hu opened this issue Mar 17, 2022 · 0 comments · Fixed by #3583
Assignees
@RickWinter
Labels
Azure.Core bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library.

Comments

@Jinming-Hu
Copy link
Member

Found a typo when reviewing the file

azure-sdk-for-cpp/sdk/core/azure-core/src/http/winhttp/win_http_transport.cpp

Line 263 in abb6ac0

BOOL tcp_false_start = TRUE;

should be tls_false_start
@Jinming-Hu Jinming-Hu added bug This issue requires a change to an existing behavior in the product in order to be resolved. Azure.Core Client This issue points to a problem in the data-plane of the library. labels Mar 17, 2022
@RickWinter RickWinter mentioned this issue Apr 22, 2022
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@RickWinter RickWinter

Labels
Azure.Core bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix typo in win http source: tcp_false_start -> tls_false_start RickWinter/azure-sdk-for-cpp
2 participants
@RickWinter @Jinming-Hu