Add eTag field for consumption API

[stephybun]

Feature Request

Hello, we're using this sdk to perform CRUD operations on budgets on subscription and resource group level. In order to update certain fields in a budget the eTag of the budget needs to be sent in the update request. Unfortunately the current consumption API version from 2019-10-01 does not have support for the eTag yet - as an example see BudgetProperties below.

type BudgetProperties struct {
	// Category - The category of the budget, whether the budget tracks cost or usage.
	Category *string `json:"category,omitempty"`
	// Amount - The total amount of cost to track with the budget
	Amount *decimal.Decimal `json:"amount,omitempty"`
	// TimeGrain - The time covered by a budget. Tracking of the amount will be reset based on the time grain. BillingMonth, BillingQuarter, and BillingAnnual are only supported by WD customers. Possible values include: 'TimeGrainTypeMonthly', 'TimeGrainTypeQuarterly', 'TimeGrainTypeAnnually', 'TimeGrainTypeBillingMonth', 'TimeGrainTypeBillingQuarter', 'TimeGrainTypeBillingAnnual'
	TimeGrain TimeGrainType `json:"timeGrain,omitempty"`
	// TimePeriod - Has start and end date of the budget. The start date must be first of the month and should be less than the end date. Budget start date must be on or after June 1, 2017. Future start date should not be more than twelve months. Past start date should  be selected within the timegrain period. There are no restrictions on the end date.
	TimePeriod *BudgetTimePeriod `json:"timePeriod,omitempty"`
	// Filter - May be used to filter budgets by user-specified dimensions and/or tags.
	Filter *BudgetFilter `json:"filter,omitempty"`
	// CurrentSpend - READ-ONLY; The current amount of cost which is being tracked for a budget.
	CurrentSpend *CurrentSpend `json:"currentSpend,omitempty"`
	// Notifications - Dictionary of notifications associated with the budget. Budget can have up to five notifications.
	Notifications map[string]*Notification `json:"notifications"`
	// ForecastSpend - READ-ONLY; The forecasted cost which is being tracked for a budget.
	ForecastSpend *ForecastSpend `json:"forecastSpend,omitempty"`
}

Can you please add support for the eTag field?

[Alancere]

Hi @stephybun thanks for this issue!

Our SDK is generated based on swagger. I checked swagger after 2019-10-01 and there is no eTag attribute in BudgetProperties. Sorry for that.

[ghost]

Hi, we're sending this friendly reminder because we haven't heard back from you in a while. We need more information about this issue to help address it. Please be sure to give us your input within the next 7 days. If we don't hear back from you within 14 days of this comment the issue will be automatically closed. Thank you!

[stephybun]

Thanks for the response @804873052, could you then please add the field to the swagger spec so that it can be generated in the SDK?

[Alancere]

@stephybun Swagger is maintained by the service team and I cannot modify it directly. I found that Budget has a root level ETag field, you see https://github.com/Azure/azure-sdk-for-go/blob/main/services/consumption/mgmt/2019-10-01/consumption/models.go#L232

[stephybun]

@804873052 thanks for pointing the field out on root level, must have missed it. Unfortunately the reason we thought we needed the ETag was for toggling the thresholdType in the notification for a budget, but even when sending the ETag along in the request the field still isn't properly updated. You can close this issue - I will raise a new one in the swagger repo.
Update: Issue in swagger repo Azure/azure-rest-api-specs#16240

[lirenhe]

Close this one as this is related to Swagger/service behaviour.
@stephybun, could you link the new issue in Swagger repo here?