Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise error types and usage #15687

Closed
chlowell opened this issue Oct 1, 2021 · 0 comments · Fixed by #15924
Closed

Revise error types and usage #15687

chlowell opened this issue Oct 1, 2021 · 0 comments · Fixed by #15924
Assignees
@chlowell
Labels
Azure.Identity blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.
Milestone
[2021] November

Comments

@chlowell
Copy link
Member

chlowell commented Oct 1, 2021

AuthenticationFailedError and CredentialUnavailableError would be more flexible as interfaces (see e.g. https://github.com/jhendrixMSFT/azure-sdk-for-go/blob/azidentity_msal/sdk/azidentity/errors.go).

These errors are also sometimes returned when a simple errors.New() would be better. For example, constructors often return CredentialUnavailableError.
@chlowell chlowell added Azure.Identity Client This issue points to a problem in the data-plane of the library. labels Oct 1, 2021
@chlowell chlowell added this to the [2021] November milestone Oct 1, 2021
@chlowell chlowell self-assigned this Oct 1, 2021
@RickWinter RickWinter added the feature-request This issue requires a new behavior in the product in order be resolved. label Oct 4, 2021
@chlowell chlowell added the blocking-release Blocks release label Oct 21, 2021
@chlowell chlowell mentioned this issue Oct 25, 2021
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chlowell chlowell

Labels
Azure.Identity blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.
Projects
None yet
Milestone
[2021] November
Development

Successfully merging a pull request may close this issue.

Revise azidentity errors chlowell/azure-sdk-for-go
2 participants
@RickWinter @chlowell