Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azcore: idempotent operations that return an io.ReadCloser should have reliable reading #19755

Open
jhendrixMSFT opened this issue Jan 5, 2023 · 1 comment
Labels
Azure.Core CodeGen Issues that relate to code generation design-discussion An area of design currently under discussion and open to team and community feedback. feature-request This issue requires a new behavior in the product in order be resolved.
Milestone

Comments

@jhendrixMSFT
Copy link
Member

Right now we simply expose the io.ReadCloser from the HTTP response body. If reading transiently fails, there is no retry. We should wrap the response in a retriable reader if the operation is idempotent. We can still expose it as an io.ReadCloser.

This requires codegen changes and possible supporting machinery in azcore.

@jhendrixMSFT jhendrixMSFT added CodeGen Issues that relate to code generation Azure.Core labels Jan 5, 2023
@RickWinter RickWinter added this to the Backlog milestone Aug 9, 2024
@RickWinter RickWinter added the feature-request This issue requires a new behavior in the product in order be resolved. label Aug 9, 2024
@RickWinter RickWinter added the design-discussion An area of design currently under discussion and open to team and community feedback. label Dec 9, 2024
Copy link

github-actions bot commented Jan 8, 2025

Hi @jhendrixMSFT, we deeply appreciate your input into this project. Regrettably, this issue has remained unresolved for over 2 years and inactive for 30 days, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 8, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2025
@jhendrixMSFT jhendrixMSFT reopened this Jan 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Core CodeGen Issues that relate to code generation design-discussion An area of design currently under discussion and open to team and community feedback. feature-request This issue requires a new behavior in the product in order be resolved.
Projects
None yet
Development

No branches or pull requests

2 participants