Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape single quotes on partition/row keys #21048

Closed
davidandradeduarte opened this issue Jun 23, 2023 · 1 comment · Fixed by #21232
Closed

Escape single quotes on partition/row keys #21048

davidandradeduarte opened this issue Jun 23, 2023 · 1 comment · Fixed by #21232
Assignees
@jhendrixMSFT
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Tables

Comments

@davidandradeduarte
Copy link

davidandradeduarte commented Jun 23, 2023 •
edited
Loading

Bug Report

Reported version:
github.com/Azure/azure-sdk-for-go/sdk/data/aztables v1.0.1

The current table storage SDK doesn't escape single quotes in partition and row keys. This means an API Bad Request whenever we use single quotes in these fields.

I would expect that the API could handle this, instead of clients escaping every string they send to PK/RK, because most times you wouldn't know.

I can try to raise a PR to fix this.

Here's a repro: https://github.com/davidandradeduarte/azurite-escape-odata-bug (this was initially meant to test azurite, but you can also reproduce the issue with a real storage account)
@github-actions github-actions bot added Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-triage Workflow: This issue needs the team to triage. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Tables labels Jun 23, 2023
@jhendrixMSFT jhendrixMSFT removed the needs-team-triage Workflow: This issue needs the team to triage. label Jun 23, 2023
@jhendrixMSFT jhendrixMSFT self-assigned this Jun 23, 2023
@github-actions github-actions bot added the needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team label Jun 23, 2023
@jhendrixMSFT jhendrixMSFT mentioned this issue Jul 20, 2023
Merged
@jhendrixMSFT
Copy link
Member

This has been fixed in [email protected]

@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jhendrixMSFT jhendrixMSFT

Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Tables
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Escape single-quote characters in partition and row keys jhendrixMSFT/azure-sdk-for-go
2 participants
@jhendrixMSFT @davidandradeduarte