Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panic Handling In Clients #23912

Open
Bharat-Goyal opened this issue Jan 7, 2025 · 2 comments · May be fixed by #23992
Open

Panic Handling In Clients #23912

Bharat-Goyal opened this issue Jan 7, 2025 · 2 comments · May be fixed by #23992
Assignees
@tanyasethi-msft
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Storage Storage Service (Queues, Blobs, Files)

Comments

@Bharat-Goyal
Copy link

Bug Report

  • import path of package in question, e.g. sdk/storage/azdatalake/v1.3.0/sdk/storage/azdatalake/file/client.go

  • SDK version 1.3.0

  • output of go version : go version go1.23.4 linux/amd64

  • What happened?
  • If the ClientWithoutAuth is used for filesystem, directory or file clients, then there is no verification for the responses. Eg: if I use an invalid sas and call GetProperties then there's a panic here because resp is nil. This will happen for all the requests.
  • What did you expect or want to happen?
  • There should not be a panic, it should be an error that's returned by the sdk.
  • How can we reproduce it?
  • Use a valid blob endpoint/container url with an invalid sas using this function
  • Anything we should know about your environment.
  • Nothing per say.
@github-actions github-actions bot added Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team. Storage Storage Service (Queues, Blobs, Files) labels Jan 7, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2025

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @xgithubtriage.

@jhendrixMSFT jhendrixMSFT removed the Service Attention Workflow: This issue is responsible by Azure service team. label Jan 7, 2025
@tanyasethi-msft
Copy link
Member

Hi @Bharat-Goyal
Thanks for reporting this. We will be fixing this before our next release, and keep this thread updated.

@tanyasethi-msft tanyasethi-msft linked a pull request Jan 22, 2025 that will close this issue
Fix panic when invalid sas is passed to get-properties call #23992
Open
5 tasks
@tanyasethi-msft tanyasethi-msft linked a pull request Jan 22, 2025 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tanyasethi-msft tanyasethi-msft

Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix panic when invalid sas is passed to get-properties call Azure/azure-sdk-for-go
3 participants
@jhendrixMSFT @Bharat-Goyal @tanyasethi-msft