Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQ] Add the ability to customize the scheduler used for timeouts/delays instead of creating a Schedulers.parallel by default on the blob storage client #17272

Closed
2 tasks done
fcofdez opened this issue Nov 6, 2020 · 4 comments
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. feature-request This issue requires a new behavior in the product in order be resolved. Storage Storage Service (Queues, Blobs, Files)

Comments

@fcofdez
Copy link
Contributor

fcofdez commented Nov 6, 2020

Is your feature request related to a problem? Please describe.
Currently in all the code handling timeouts/delayed subscriptions (at least on the storage project see [1], [2]) use by default the Schedulers.parallel() which might be convenient in some cases but it doesn't allow a fine grained control of the resources used by the client.

Describe the solution you'd like
I would like to be able to inject a ScheduledExecutorService to be used in those cases, avoiding any unintended thread pool creation.

Describe alternatives you've considered
I was able to circumvent this limitation partially (i.e. creating a custom HttpPipeline that uses a custom request retry policy),
but in other parts of the client it's impossible to inject a custom Scheduler

Additional context
It seems like in other parts of the SDK this was possible at some point, see #5466

Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

  • Description Added
  • Expected solution specified
@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Nov 6, 2020
@fcofdez
Copy link
Contributor Author

fcofdez commented Nov 6, 2020

I've just noticed that reactor Schedulers allows to inject a custom factory, but in any case that's an implementation detail that should be hidden from the users.

@alzimmermsft alzimmermsft added Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files) labels Nov 6, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Nov 6, 2020
@alzimmermsft alzimmermsft added feature-request This issue requires a new behavior in the product in order be resolved. and removed question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Nov 6, 2020
@rickle-msft
Copy link
Contributor

@JonathanGiles Do you have thoughts on how we should expose this to the public API surface?

@JonathanGiles
Copy link
Member

Thanks for the feature request @fcofdez. I'll give some thought on how we could expose this. One option we have is to make this a configuration option present in our ClientOptions type. That would mean that we would apply this to all clients that are given this ClientOptions instance in their builder (and we are still in the process of introducing ClientOptions to all builders).

fixmebot bot referenced this issue in VectorXz/elasticsearch Apr 22, 2021
fixmebot bot referenced this issue in VectorXz/elasticsearch May 28, 2021
fixmebot bot referenced this issue in VectorXz/elasticsearch Aug 4, 2021
Copy link

Hi @fcofdez, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 20, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. feature-request This issue requires a new behavior in the product in order be resolved. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

No branches or pull requests

4 participants