Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding VmUniqueId in cosmosDiagnostics and clientTelemetry #27689

Closed
xinlian12 opened this issue Mar 15, 2022 · 1 comment · Fixed by #27692
Closed

Adding VmUniqueId in cosmosDiagnostics and clientTelemetry #27689

xinlian12 opened this issue Mar 15, 2022 · 1 comment · Fixed by #27692
Assignees
@FabianMeiswinkel
Labels
Client This issue points to a problem in the data-plane of the library. cosmos:v4-item Indicates this feature will be shipped as part of V4 release train Cosmos
Milestone
Backlog

Comments

@xinlian12
Copy link
Member

Consider adding VmUniqueId in the cosmos diagnostics and client telemetry. (The vmId is meant to be used for licensing etc. as a machine identifier - so should be safe to be used for us as well)

if available - if instance metadata is not available we can use a hash of the machine name instead (to avoid any PII issues)
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Mar 15, 2022
@xinlian12 xinlian12 added Cosmos cosmos:v4-item Indicates this feature will be shipped as part of V4 release train labels Mar 15, 2022
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Mar 15, 2022
@ghost
Copy link

ghost commented Mar 15, 2022

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @kushagraThapar, @simplynaveen20, @abinav2307

@xinlian12 xinlian12 added this to the Backlog milestone Mar 15, 2022
@kushagraThapar kushagraThapar added the Client This issue points to a problem in the data-plane of the library. label Mar 15, 2022
@FabianMeiswinkel FabianMeiswinkel mentioned this issue Mar 15, 2022
Merged
6 tasks
@FabianMeiswinkel FabianMeiswinkel self-assigned this Mar 15, 2022
@FabianMeiswinkel FabianMeiswinkel linked a pull request Mar 15, 2022 that will close this issue
Extracting vmId form Azure instance metadata #27692
Merged
6 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@FabianMeiswinkel FabianMeiswinkel

Labels
Client This issue points to a problem in the data-plane of the library. cosmos:v4-item Indicates this feature will be shipped as part of V4 release train Cosmos
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Extracting vmId form Azure instance metadata FabianMeiswinkel/azure-sdk-for-java
3 participants
@kushagraThapar @FabianMeiswinkel @xinlian12