[Service Bus] Inconsistencies with errors when settling deferred message in ReceiveAndDelete mode

[ramya-rao-a]

In the below JavaScript code using Service Bus version 7.0.0-preview.4, we

• send a message
• receive and defer the message
• receive this deferred message in ReceiveAndDelete mode
• settle this receive message, catch any error thrown at this point

The expectation is that the client throws a meaningful error as the message cannot be settled due to it being received in ReceiveAndDelete mode.

const { ServiceBusClient } = require("@azure/service-bus");

const connectionString = "connection string here";
const queueName = "queue name here";

async function main() {
  const sbClient = new ServiceBusClient(connectionString);

 // Send message
  const sender = sbClient.createSender(queueName);
  await sender.sendMessages({
    body: "hello2"
  })

 // Receive in PeekLock mode and defer
  let peekLockReceiver =  sbClient.createReceiver(queueName, "peekLock");
  const [msg] = await peekLockReceiver.receiveMessages(1);
  await msg.defer();
  await peekLockReceiver.close();

 // Receive deferred msg in ReceiveAndDelete mode and complete it
  let receiveAndDeleteReceiver =  sbClient.createReceiver(queueName, "receiveAndDelete");
  const [deferredMsg] = await receiveAndDeleteReceiver.receiveDeferredMessages(msg.sequenceNumber);

  try {
    await deferredMsg.complete();
  } catch (error) {
    console.log("Error when completing deferred message in Receive And Delete mode:", error)
  }
  await sbClient.close();
}

main();

Inconsistent results:

• We see the TypeError: Cannot read property 'name' of undefined error in below cases
  • unpartitioned queue
  • unpartitioned subscriptions
  • partitioned subscriptions with sessions
  • unpartitioned subscriptions with sessions
  • partitioned queue with sessions
  • unpartitioned queue with sessions
• We see no errors with
  • partitioned queue
  • partitioned subscriptions

Where as trying to settle a normal i.e. non deferred message received in ReceiveAndDelete mode gives a very useful error "Failed to complete the message as the operation is only supported in 'PeekLock' receive mode"

[ramya-rao-a]

Same problem for when trying to renew lock on a deferred message that was received in Receive And Delete mode.

We see the TypeError: Cannot read property 'name' of undefined error in below cases

• unpartitioned queue
• unpartitioned subscriptions

We see no errors with

• partitioned queue
• partitioned subscriptions

Where as trying to renew lock on a normal i.e. non deferred message received in ReceiveAndDelete mode gives a very useful error "Failed to renew lock on the message as the operation is only supported in 'PeekLock' receive mode"

[ramya-rao-a]

The root cause for why the partitioned queue/subscription with no sessions return no error from the service is most probably the same as the one for #2268, but we should be able to do better on the client side even if the service is buggy

[ramya-rao-a]

Fixed with #10396