Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Key Vault] Stop using the spread operator. #11720

Closed
sadasant opened this issue Oct 8, 2020 · 2 comments
Closed

[Key Vault] Stop using the spread operator. #11720

sadasant opened this issue Oct 8, 2020 · 2 comments
Assignees
@sadasant
Labels
Client This issue points to a problem in the data-plane of the library. good first issue This issue tracks work that may be a good starting point for a first-time contributor KeyVault
Milestone
MQ-2020

Comments

@sadasant
Copy link
Contributor

sadasant commented Oct 8, 2020

The spread operator leaves room for inconsistencies in the supported properties. The Key Vault clients use this operator a bunch. We should clean this up. The last time this was pointed out was by Jeff here: #11717 (comment)
@sadasant sadasant added good first issue This issue tracks work that may be a good starting point for a first-time contributor Client This issue points to a problem in the data-plane of the library. KeyVault labels Oct 8, 2020
@sadasant sadasant added this to the MQ-2020 milestone Oct 8, 2020
@sadasant sadasant self-assigned this Oct 8, 2020
@sadasant sadasant mentioned this issue Oct 8, 2020
Merged
@ramya-rao-a
Copy link
Contributor

Doesnt #9730 cover the same thing?

@sadasant
Copy link
Contributor Author

sadasant commented Oct 9, 2020

@ramya-rao-a That is true! Thank you! I'll close this one.

@sadasant sadasant closed this as completed Oct 9, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sadasant sadasant

Labels
Client This issue points to a problem in the data-plane of the library. good first issue This issue tracks work that may be a good starting point for a first-time contributor KeyVault
Projects
None yet
Milestone
MQ-2020
Development

No branches or pull requests
2 participants
@sadasant @ramya-rao-a