Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MetricsAdvisor] Remove extra GET calls from Update methods #13392

Closed
jeremymeng opened this issue Jan 26, 2021 · 0 comments · Fixed by #13485
Closed

[MetricsAdvisor] Remove extra GET calls from Update methods #13392

jeremymeng opened this issue Jan 26, 2021 · 0 comments · Fixed by #13485
Assignees
@KarishmaGhiya
Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Metrics Advisor
Milestone
[2021] February

Comments

@jeremymeng
Copy link
Member

The return type should be RestResponse, similar to return types of Delete methods. We don't need to return more information in order to know whether update process succeeds.
@jeremymeng jeremymeng added Client This issue points to a problem in the data-plane of the library. Cognitive - Metrics Advisor labels Jan 26, 2021
@jeremymeng jeremymeng added this to the [2021] February milestone Jan 26, 2021
@KarishmaGhiya KarishmaGhiya mentioned this issue Jan 28, 2021
Closed
@KarishmaGhiya KarishmaGhiya linked a pull request Jan 29, 2021 that will close this issue
Update functions modified to remove Get calls #13485
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@KarishmaGhiya KarishmaGhiya

Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Metrics Advisor
Projects
None yet
Milestone
[2021] February
Development

Successfully merging a pull request may close this issue.

Update functions modified to remove Get calls KarishmaGhiya/azure-sdk-for-js
2 participants
@jeremymeng @KarishmaGhiya