Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Samples demonstrating implementing Token Credential directly with MSAL / ADAL #17283

Closed
g2vinay opened this issue Aug 26, 2021 · 3 comments
Closed

Add Samples demonstrating implementing Token Credential directly with MSAL / ADAL #17283

g2vinay opened this issue Aug 26, 2021 · 3 comments
Assignees
@sadasant @g2vinay
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library. issue-addressed Workflow: The Azure SDK team believes it to be addressed and ready to close.
Milestone
[2021] September

Comments

@g2vinay
Copy link
Member

g2vinay commented Aug 26, 2021

Add Samples explaining how to implement a Token Credential that directly uses MSAL clients.
Port the sample from here
@g2vinay g2vinay added Client This issue points to a problem in the data-plane of the library. Azure.Identity labels Aug 26, 2021
@sadasant
Copy link
Contributor

We have a sample here: https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/identity/identity/samples/AzureIdentityExamples.md#authenticating-with-msal-directly your review is appreciated!

@sadasant sadasant added this to the [2021] September milestone Aug 26, 2021
@sadasant sadasant added the issue-addressed Workflow: The Azure SDK team believes it to be addressed and ready to close. label Aug 27, 2021
@ghost
Copy link

ghost commented Aug 27, 2021

Hi @g2vinay. Thank you for opening this issue and giving us the opportunity to assist. We believe that this has been addressed. If you feel that further discussion is needed, please add a comment with the text “/unresolve” to remove the “issue-addressed” label and continue the conversation.

@g2vinay g2vinay mentioned this issue Aug 30, 2021
Closed
7 tasks
@sadasant
Copy link
Contributor

sadasant commented Sep 2, 2021

Since we already have a sample for this, I’m closing this issue.

@sadasant sadasant closed this as completed Sep 2, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sadasant sadasant

@g2vinay g2vinay

Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library. issue-addressed Workflow: The Azure SDK team believes it to be addressed and ready to close.
Projects
None yet
Milestone
[2021] September
Development

No branches or pull requests
2 participants
@sadasant @g2vinay