Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Perf Framework] Each parallel test instance gets own client #17773

Closed
HarshaNalluru opened this issue Sep 22, 2021 · 1 comment · Fixed by #17832
Closed

[Perf Framework] Each parallel test instance gets own client #17773

HarshaNalluru opened this issue Sep 22, 2021 · 1 comment · Fixed by #17832
Assignees
@HarshaNalluru
Labels
pillar-performance The issue is related to performance, one of our core engineering pillars.
Milestone
[2021] October

Comments

@HarshaNalluru
Copy link
Member

Currently, when used test-proxy, a single client is being re-used.
image

Update it such that each parallel test instance gets its own client to be consistent across languages.

https://github.com/Azure/azure-sdk-for-net/blob/cd1bae9fc609003b330ed2fe7a854479034377fe/common/Perf/Azure.Test.Perf/PerfProgram.cs#L121
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 22, 2021
@HarshaNalluru HarshaNalluru self-assigned this Sep 22, 2021
@HarshaNalluru HarshaNalluru added the pillar-performance The issue is related to performance, one of our core engineering pillars. label Sep 22, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 22, 2021
@HarshaNalluru HarshaNalluru added this to the [2021] October milestone Sep 22, 2021
@mikeharder
Copy link
Member

This commit is a quick hack to implement this: mikeharder@0121abf?w=1

@mikeharder mikeharder mentioned this issue Sep 23, 2021
Merged
@HarshaNalluru HarshaNalluru mentioned this issue Sep 24, 2021
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@HarshaNalluru HarshaNalluru

Labels
pillar-performance The issue is related to performance, one of our core engineering pillars.
Projects
None yet
Milestone
[2021] October
Development

Successfully merging a pull request may close this issue.

[Perf Framework] No cached proxy clients. HarshaNalluru/azure-sdk-for-js
2 participants
@mikeharder @HarshaNalluru