Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Multi-Tenant support to incorporate Arch Board Feedback #17913

Closed
schaabs opened this issue Sep 28, 2021 · 3 comments · Fixed by #17915
Closed

Update Multi-Tenant support to incorporate Arch Board Feedback #17913

schaabs opened this issue Sep 28, 2021 · 3 comments · Fixed by #17915
Assignees
@sadasant
Labels
Azure.Identity blocking-release Blocks release Client This issue points to a problem in the data-plane of the library.
Milestone
[2021] October

Comments

@schaabs
Copy link
Member

schaabs commented Sep 28, 2021

  • Allow multi-tenant authentication by default
  • Remove allowMultiTenantAuthentication option from TokenCredentialOptions
  • Change compat environment variable AZURE_IDENTITY_ENABLE_LEGACY_TENANT_SELECTION to AZURE_IDENTITY_DISABLE_MULTITENANTAUTH
  • Block multi-tenant auth when credentials are configured with tenant id adfs
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 28, 2021
@schaabs schaabs added Azure.Identity blocking-release Blocks release and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Sep 28, 2021
@sadasant
Copy link
Contributor

We never had AZURE_IDENTITY_ENABLE_LEGACY_TENANT_SELECTION, so for us is about adding support to AZURE_IDENTITY_DISABLE_MULTITENANTAUTH.

@sadasant sadasant mentioned this issue Sep 28, 2021
Merged
@ramya-rao-a
Copy link
Contributor

@sadasant Is this for the October release? Can you please set the appropriate milestone?

@ramya-rao-a ramya-rao-a added the Client This issue points to a problem in the data-plane of the library. label Sep 28, 2021
@sadasant sadasant added this to the [2021] October milestone Sep 28, 2021
@sadasant
Copy link
Contributor

@ramya-rao-a Yup. October release. Updated! Thanks!

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sadasant sadasant

Labels
Azure.Identity blocking-release Blocks release Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
[2021] October
Development

Successfully merging a pull request may close this issue.

[Identity] Removed allowMultiTenantAuthentication sadasant/azure-sdk-for-js
3 participants
@sadasant @schaabs @ramya-rao-a