azure-arm-apimanagement ^5.0.0 defaults capacity to 1 for consumption sku

[annaji-msft]

• Package Name: azure-arm-apimanagement

• Package Version: ^5.0.0

• Operating system: Windows

• nodejs

  • 6.8.0:

Describe the bug
defaults capacity to 1 for consumption sku. This is causing a bad request returned by the server as it expects no capacity property for consumption sku.

To Reproduce
Steps to reproduce the behavior:

1. Create a consumption sku api management service

let serviceResource = {
location: "west us",
sku: <ApiManagementModels.ApiManagementServiceSkuProperties>{
name: "Consumption"
},
publisherEmail: [email protected]
publisherName: "foo"
};

Expected behavior
Must create a api management service with consumption sku

Actual Behavior
{"code":"InvalidParameters","message":"Invalid parameter: Specifying Sku Capacity for Sku Type 'Consumption' is invalid.","details":null,"innerError":null}

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

[jhendrixMSFT]

@kpajdzik is the generator inserting this? Per swagger spec default indicates a value the server will use if none is provided, codegen shouldn't be populating this.

[kpajdzik]

Seems like it: https://github.com/Azure/azure-sdk-for-node/blob/e1887b81ee4f1b0d540d6b63c84c542829036edd/lib/services/apimanagement/lib/models/apiManagementServiceSkuProperties.js#L52-L53

capacity: {
            required: false,
            serializedName: 'capacity',
            defaultValue: 1,
            type: {
              name: 'Number'
            }
          }

@daschult @amarzavery Any comments here?

[ramya-rao-a]

@joheredi Can you check if this is still a problem in @azure/arm-apimanagement that uses v4 of the code generator?

[joheredi]

It looks like defaultValue is no longer defined in the latest SDK using autorest.typescript v4

azure-sdk-for-js/sdk/apimanagement/arm-apimanagement/src/models/mappers.ts

Lines 4227 to 4233 in 2f5be4d

	capacity: {
	required: true,
	serializedName: "capacity",
	type: {
	name: "Number"
	}
	}