Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@azure/storage-file-share broken for Node.js 14 after latest release #28919

Closed
devatlucy opened this issue Mar 14, 2024 · 3 comments
Closed

@azure/storage-file-share broken for Node.js 14 after latest release #28919

devatlucy opened this issue Mar 14, 2024 · 3 comments
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that

Comments

@devatlucy
Copy link

devatlucy commented Mar 14, 2024 •
edited
Loading

  • **@azure/storage-file-share **:
  • 12.17.0:
  • node:14.15.4-alpine:

Describe the bug
Attempting to build a node js package results in the missing module issue
To Reproduce
Steps to reproduce the behavior:
npm i @azure/storage-file-share

Expected behavior
Since previous version of the package did support node 14, the new version should either stay backwards compatible or be published as a major release.

Error
Error: Cannot find module 'node:os'
Require stack:-
/home/app/node_modules/@azure/logger/dist/commonjs/log.js- /home/app/node_modules/@azure/logger/dist/commonjs/debug.js- /home/app/node_modules/@azure/logger/dist/commonjs/index.js- /home/app/node_modules/@azure/core-http/dist/index.js- /home/app/node_modules/@azure/storage-file-share/dist/index.js
@github-actions github-actions bot added customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Mar 14, 2024
@piyushthacker
Copy link

Getting the same error. Please provide backward compatibility, cannot migrate to node 18 overnight.

@maorleger
Copy link
Member

Hiya folks, thanks for reaching out. In order to keep conversations in a single place we will be consolidating these Node 14 issues under #28918 - please subscribe to that issue for updates. Much appreciated!

Duplicates #28918

@maorleger maorleger closed this as not planned Won't fix, can't repro, duplicate, stale Mar 14, 2024
@devatlucy
Copy link
Author

We found a workaround for this. Using the older version of @azure/logger and explicitly mentioning the version in the package.json did the job.

This was referenced May 18, 2024
Open
Open
@github-actions github-actions bot locked and limited conversation to collaborators Jun 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@maorleger @piyushthacker @devatlucy