Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update samples for next wave of releases #6280

Closed
2 tasks
kaerm opened this issue Nov 20, 2019 · 2 comments
Closed
2 tasks

Update samples for next wave of releases #6280

kaerm opened this issue Nov 20, 2019 · 2 comments
Labels
Client This issue points to a problem in the data-plane of the library. Docs

Comments

@kaerm
Copy link
Contributor

kaerm commented Nov 20, 2019

Make sure there are enough samples covering the most important scenarios and more advanced examples in the repo for the following packages:

  • storage-file-share
  • keyvault-certificates

cc: @ramya-rao-a

@kaerm kaerm added Client This issue points to a problem in the data-plane of the library. Docs labels Nov 20, 2019
@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Nov 21, 2019

#5109 is tracking the sample updates to all 3 storage libraries
We have the important scenarios for keyvault certificates already in https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/keyvault/keyvault-certificates/samples/javascript.

@jonathandturner Was there plans to add any more samples among the keyvault crew? If not, then go ahead and close this issue

@kaerm
Copy link
Contributor Author

kaerm commented Nov 21, 2019

Just want to make sure all elements are in place. If you are already done I'll be extremely happy if you close so that I can take it off my list @ramya-rao-a :)

@kaerm kaerm closed this as completed Mar 23, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Docs
Projects
None yet
Development

No branches or pull requests

2 participants