Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Event Hubs Client] All Track1 Tests fail while authrityhost from key vault secret doesn't end with "/" #17701

Closed
Luyunmt opened this issue Dec 24, 2020 · 1 comment
Closed

[Event Hubs Client] All Track1 Tests fail while authrityhost from key vault secret doesn't end with "/" #17701

Luyunmt opened this issue Dec 24, 2020 · 1 comment
Assignees
@jsquire
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs
Milestone
[2021] February

Comments

@Luyunmt
Copy link
Contributor

Luyunmt commented Dec 24, 2020 •
edited by tzhanl
Loading

We are running live Tests against other clouds like US Gov and Azure China Cloud. The goal is to check whether new azure sdk package work with other clouds or not.
Based on following code, all clouds' authorityhost must end with "/". But now from subscription configuration in key vault secret only Public end with "/".
This leads to all track 1 tests fail.
In Issue 15009, track2 Event Hub code was fixed, track1 Eventhub code need to be fixed also.

image
Now the value of AZURE_AUTHORITY_HOST from subscription configuration in key vault secret :
sub-config-azure-cloud-test-resources-test: None,so using default value : https://login.microsoftonline.com/
sub-config-cn-test-resources-test : https://login.chinacloudapi.cn
sub-config-gov-test-resources-test : https://login.microsoftonline.com
@jongio @danieljurek
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 24, 2020
@tzhanl tzhanl added Client This issue points to a problem in the data-plane of the library. Event Hubs needs-team-triage Workflow: This issue needs the team to triage. test-sovereign-cloud labels Dec 24, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 24, 2020
@Luyunmt Luyunmt closed this as completed Dec 24, 2020
@Luyunmt Luyunmt changed the title [Event Hubs Client] All Tests fail while authrityhost from key vault secret doesn't end with "/" [Event Hubs Client] All Track1 Tests fail while authrityhost from key vault secret doesn't end with "/" Dec 24, 2020
@Luyunmt Luyunmt reopened this Dec 24, 2020
@jsquire jsquire self-assigned this Dec 24, 2020
@jsquire jsquire removed the needs-team-triage Workflow: This issue needs the team to triage. label Dec 24, 2020
@jsquire jsquire added this to the [2021] February milestone Dec 24, 2020
@jsquire jsquire mentioned this issue Jan 6, 2021
Merged
@jsquire
Copy link
Member

jsquire commented Jan 9, 2021

Fixed by #17816

@jsquire jsquire closed this as completed Jan 9, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jsquire jsquire

Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs
Projects
None yet
Milestone
[2021] February
Development

No branches or pull requests
3 participants
@jsquire @tzhanl @Luyunmt