[MetricsAdvisor] Bug: service call fails when attempting to update certain Data Feeds

[kinelski]

Data Feeds created with Azure Application Insights, Azure Cosmos DB, and Azure Data Explorer always fail during update. A similar error message is returned in all scenarios. This one is the outcome of an attempt to update an Azure Application Insights Data Feed:

{"code":"BadRequest","message":"JSON parse error: Cannot deserialize value of type com.microsoft.powerai.contract.thirdparty.metadata.enumlist.DataSourceType from String "AzureApplicationInsights": value not one of declared Enum instance names: [ObjectStore, KVP, Kafka, HttpRequest, CosmosDB, Cosmos, SqlServer, MongoDB, PostgreSql, Cube, Mdm, None, EventHub, Elasticsearch, AzureTable, MySql, Kusto, DataCopIScope, JSON, DataLakeStructured, iScope, AzureBlob, AzureDataLakeStorageGen2, API, LogAnalytics, xCard, ApplicationInsights, InfluxDB]"}

Service seems to be expecting the enum instance names CosmosDB and ApplicationInsights, while the swagger specifies AzureCosmosDB and AzureApplicationInsights (AzureDataExplorer is never mentioned in the error message).

12 tests were disabled in DataFeedLiveTests because of this bug. All of them need to be enabled again once this is fixed.

[ghost]

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @wmengmsft, @MehaKaushik, @shurd

[kinelski]

After investigation, this seems an issue about swagger inconsistency with the actual behavior of the service. The swagger defines the following possible dataSourceTypes during an update: AzureApplicationInsights, AzureCosmosDB, and AzureDataExplorer.

However, the service expects the following strings during update: ApplicationInsights, CosmosDB, and Kusto, respectively. This is inconsistent with the behavior of the CreateDataFeed method as well.

Follow-up: discuss with the service team about what's the expected behavior and what should be updated (client, service, or swagger).