Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor teardown tasks in Key Vault tests #26794

Closed
heaths opened this issue Feb 4, 2022 · 1 comment
Closed

Refactor teardown tasks in Key Vault tests #26794

heaths opened this issue Feb 4, 2022 · 1 comment
Assignees
@heaths
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Milestone
Backlog

Comments

@heaths
Copy link
Member

heaths commented Feb 4, 2022

Similar to temporary changes made in PR #26793, we may want to refactor out all the teardown tasks that call Recording.DisableRecording() and instead use a non-instrumented client. This would be an alternative to Azure/azure-sdk-tools#2434 depending on if and when changes are made.

This will need to be done before we re-record all our tests for 7.3 GA.

/cc @JoshLove-msft
@heaths heaths added KeyVault Client This issue points to a problem in the data-plane of the library. labels Feb 4, 2022
@heaths heaths added this to the [2022] March milestone Feb 4, 2022
@heaths heaths self-assigned this Feb 4, 2022
@jsquire jsquire modified the milestones: [2022] March, Backlog Mar 16, 2022
@heaths heaths modified the milestones: Backlog, [2022] April Mar 16, 2022
@jsquire jsquire modified the milestones: [2022] April, Backlog Apr 15, 2022
@heaths heaths modified the milestones: Backlog, [2022] May Apr 15, 2022
@heaths heaths modified the milestones: [2022] May, Backlog Apr 19, 2022
@heaths
Copy link
Member Author

heaths commented Jul 20, 2023

I don't believe there's enough value to prioritize.

@heaths heaths closed this as not planned Won't fix, can't repro, duplicate, stale Jul 20, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@heaths heaths

Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
Azure SDK for Key Vault
Archived in project
Milestone
Backlog
Development

No branches or pull requests
2 participants
@jsquire @heaths