Ensure all StorageWriteStream disposables are disposed #47783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the other calls within Dispose can error out, there needs to be a try around them so even if they fail, the _accumulatedDisposables can still be disposed after they are complete to prevent resource leakage.
rlrossiter
requested review from
seanmcc-msft,
amnguye,
jaschrep-msft,
schaabs,
tg-msft,
jalauzon-msft and
nickliu-msft
as code owners
github-actions
bot
added
Community Contribution
|
Thank you for your contribution @rlrossiter! We will review the pull request and get back to you soon. |
|
API change check API changes are not detected in this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the other calls within Dispose can error out, there needs to be a try around them so even if they fail, the _accumulatedDisposables can still be disposed after they are complete to prevent resource leakage.
Fixes #47781