Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable SourceLink for .NET projects #6239

Closed
weshaggard opened this issue May 10, 2019 · 5 comments
Closed

Enable SourceLink for .NET projects #6239

weshaggard opened this issue May 10, 2019 · 5 comments
Assignees
Labels
EngSys This issue is impacting the engineering system.

Comments

@weshaggard
Copy link
Member

See https://github.com/dotnet/SourceLink for how to enable SourceLink. This will give us the ability to debug through the source code of our libraries as well as it will add some additional metadata to the information version that points to the sha of the source when it was built.

@weshaggard weshaggard added the EngSys This issue is impacting the engineering system. label May 10, 2019
@weshaggard
Copy link
Member Author

weshaggard commented Jul 10, 2019

@tmat Do we still need to reference the SourceLink package or if we are using the .NET Core 3 SDK is the support built in?

@tmat
Copy link

tmat commented Jul 10, 2019

Yes, there is no plan to include SourceLink in the SDK.

@weshaggard
Copy link
Member Author

@chidozieononiwu looks like there are some projects that already reference SourceLink (https://github.com/Azure/azure-sdk-for-net/search?q=sourcelink&unscoped_q=sourcelink) which is why @mitchdenny said it worked for some he tried already. Please move that package reference to the common targets file and update the version to the latest published on nuget.org.

@SeanFeldman
Copy link
Contributor

It was extremely convenient to step into the code w/o the need to set up symbols server.
I'd like to ask what was the reason SourceLink was disqualified?

@weshaggard
Copy link
Member Author

We have enabled SourceLink for all our data-plane packages by default, see PR #6867. If you are seeing something not working please let us know.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
EngSys This issue is impacting the engineering system.
Projects
None yet
Development

No branches or pull requests

4 participants