Feature/storage/put blob from url #15978
Conversation
seanmcc-msft
requested review from
amishra-dev,
amnguye,
kasobol-msft,
KrzysztofCwalina and
tg-msft
as code owners
ghost
added
the
|
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
| @@ -936,6 +941,16 @@ public enum BlobType | |||
| Page = 1, | |||
| Append = 2, | |||
| } | |||
| public partial class BlobUploadFromUriOptions | |||
There was a problem hiding this comment.
this should take metadata as well.
There was a problem hiding this comment.
Unfortunately there is a service bug, setting metadata on doesn't currently work.
| { | ||
| public BlobUploadFromUriOptions() { } | ||
| public Azure.Storage.Blobs.Models.AccessTier? AccessTier { get { throw null; } set { } } | ||
| public Azure.Storage.Blobs.Models.BlobCopySourceBlobPropertiesOption CopySourceBlobPropertiesOption { get { throw null; } set { } } |
There was a problem hiding this comment.
this is boolean on the server side. enum might be overkill.
There was a problem hiding this comment.
The issue here is that the server side bool is true by default. This violates One SDK's guidelines.
x-ms-copy-source-blob-properties: true/false. Optional. Specifies whether the properties of the source blob should be copied to the destination. This is true by default. If false, no properties from the source blob are copied, and only those properties provided in the request are applied to the destination blob.
There was a problem hiding this comment.
@tg-msft should we invert boolean or keep enum ?
There was a problem hiding this comment.
Could we use bool? CopyBlobProperties { get; set; } where the default null means do whatever the service wants? That might also help make it clear customers only need to think about setting it when they're doing a copy vs. uploading a random URI?
There was a problem hiding this comment.
Sounds good to me. That's how Java equivalent is implemented now.
| @@ -2160,6 +2160,195 @@ protected sealed override BlobBaseClient WithSnapshotCore(string snapshot) | |||
| } | |||
| #endregion OpenWrite | |||
|
|
|||
| #region PutBlobFromUrl | |||
There was a problem hiding this comment.
nit. region name is out of date.
| await sourceBlob.UploadAsync(stream, uploadOptions); | ||
|
|
||
| // Act | ||
| await destBlob.UploadFromUriAsync(sourceBlob.Uri); |
There was a problem hiding this comment.
should we assert response ?
There was a problem hiding this comment.
We just care the the service returns a 200, otherwise a RequestFailedException would be thrown here.
There was a problem hiding this comment.
don't we care about parsing response correctly ?
| @@ -2160,6 +2160,195 @@ protected sealed override BlobBaseClient WithSnapshotCore(string snapshot) | |||
| } | |||
| #endregion OpenWrite | |||
|
|
|||
| #region UploadFromUri | |||
| /// <summary> | |||
| /// The Put Blob from URL operation creates a new Block Blob where the contents of the | |||
There was a problem hiding this comment.
Should this be updated to "The Upload From URL operation", or should we stick with what the REST API operation is called?
No description provided.