GetDateTimeOffset and fix pageSizeHint for Pageable #16446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
christothes
added
the
Client
pakrym
reviewed
Oct 29, 2020
| Assert.That(page.Values, Is.Not.Empty); | ||
| if (pageCount.HasValue) | ||
| { | ||
| Assert.That(page.Values.Count, Is.EqualTo(Math.Min(pageCount.Value, remainingItems))); |
There was a problem hiding this comment.
Isn't that less precise than what is there now?
pakrym
reviewed
Oct 29, 2020
pakrym
approved these changes
Oct 29, 2020
christothes
requested review from
KrzysztofCwalina and
tg-msft
as code owners
|
Hello @christothes! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
annelo-msft
pushed a commit
to annelo-msft/azure-sdk-for-net
that referenced
this pull request
Feb 17, 2021
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #14002
fixes #13921