Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't install NET5 #17281

Merged
2 commits merged into from
Jan 4, 2021
Merged

Don't install NET5 #17281

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5839b64
Don't install NET5
pakrym Dec 2, 2020
7de9542
Update install-dotnet.yml
pakrym Jan 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 1 addition & 13 deletions eng/pipelines/templates/steps/install-dotnet.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1 @@
steps:
- task: UseDotNet@2
displayName: 'Use .NET Core SDK'
condition: ne(variables['Agent.OS'], 'Windows_NT') # Windows supports MultiLevelLookup and doesn't need explicit framework installation
inputs:
useGlobalJson: true
performMultiLevelLookup: true
- task: UseDotNet@2
condition: ne(variables['Agent.OS'], 'Windows_NT') # Windows supports MultiLevelLookup and doesn't need explicit framework installation
displayName: 'Use .NET Core 2.1 runtime'
inputs:
packageType: runtime
version: "2.1.x"
steps: []
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: @mitchdenny

@pakrym we should at least add a comment here. We might even want to consider adding a verification step.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lately, the installation step was fast and non-flaky. Should we keep it instead of the verification?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way I would do this is comment the tasks out with a brief comment at the top explaining that they can be commented back in when a new version of .NET is released and the hosted agents don't yet have the bits. I think this is something we'll oscillate on a lot.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comments/kept commented out steps.