-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added az networking api for 2021-05-01 version #24883
Conversation
The metadata file was not included. But interestingly enough, the codegen verification did NOT fail. Need to take a look. |
Fixed metadata + regenerated. |
@MikhailTryakhov approved, but please fix the failed build. |
/azp run |
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
@Yao725 can you please help me to rerun these jobs? They were succeeded last time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MikhailTryakhov Generally it's good. Just spotted a breaking change and some places need customization for backward compatibility.
- If the breaking change is expected, then you can update the major version and you don't need to provide customization.
sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/BackendAddressPool.cs
Show resolved
Hide resolved
...etwork/Microsoft.Azure.Management.Network/src/Generated/Models/LoadBalancerBackendAddress.cs
Show resolved
Hide resolved
sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/NetworkInterface.cs
Show resolved
Hide resolved
sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/VirtualNetwork.cs
Show resolved
Hide resolved
sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/VirtualNetworkGateway.cs
Show resolved
Hide resolved
sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/VirtualNetworkPeering.cs
Show resolved
Hide resolved
sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/CustomIpPrefix.cs
Show resolved
Hide resolved
@archerzz changed sdk version, please review/merge in case it's ok for you |
57615d1
to
f6b61c8
Compare
Hi @MikhailTryakhov , it looks like that there is something wrong with the provided commit id . The ci failed here because the link just points to a readme.md which doesn't exist, so please correct it. |
@Yao725 can we sync up quickly? I can't find any ways to generate this metadata (ran Start-AutoRestCodeGeneration - same data generated, updated PR) |
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them. In order to bootstrap pipelines for a new service, please perform following steps: For data-plane/track 2 SDKs Issue the following command as a pull request comment:
For track 1 management-plane SDKsPlease open a separate PR and to your service SDK path in this file. Once that PR has been merged, you can re-run the pipeline to trigger the verification. |
@MikhailTryakhov In the |
/azp run net - mgmt - ci |
Azure Pipelines successfully started running 1 pipeline(s). |
@MikhailTryakhov It's a known issue for RPs having large swagger files. I've re-started the failed job, and will keep an eye on it. The SDK should be ready to go, just needs to pass the build... Hopefully when track2 is GA, we don't need to suffer from this again. |
Thanks a lot @archerzz |
All SDK Contribution checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.
Draft
mode if it is:Network may release: monthly branch release from Azure Networking side. azure-rest-api-specs#16395
General Guidelines and Best Practices
Testing Guidelines
SDK Generation Guidelines
*.csproj
andAssemblyInfo.cs
files have been updated with the new version of the SDK. Please double check nuget.org current release version.Additional management plane SDK specific contribution checklist:
Note: Only applies to
Microsoft.Azure.Management.[RP]
orAzure.ResourceManager.[RP]
Management plane SDK Troubleshooting
If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add
new service
label and/or contact assigned reviewer.If the check fails at the
Verify Code Generation
step, please ensure:generate.ps1/cmd
to generate this PR instead of callingautorest
directly.Please pay attention to the @microsoft.csharp version output after running
generate.ps1
. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.Note: We have recently updated the PSH module called by
generate.ps1
to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.