Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nithin/sdkupdates 2019 06 version #6645

Merged
merged 3 commits into from
Jun 27, 2019

Conversation

nithinpnp
Copy link
Contributor

changes -
We have added optional fields for WebhookReceiver model in Swagger Spec. Updating the SDK to reflect the same.
incremented the version number .

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@erich-wang
Copy link
Member

@nithinpnp, could you share the swagger specs PR link related to this change?

@erich-wang
Copy link
Member

/azp run net - mgmt - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@erich-wang erich-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nithinpnp , please follow the instruction to:

  • Update AssemblyVersion and AssemblyFileVersion in AssemblyInfo.cs if needed
  • Update AzureApiTag in AzSDk.RP.props

@nithinpnp
Copy link
Contributor Author

@erich-wang . The instructions to follow link is broken , Could you please get the latest link ?

@erich-wang
Copy link
Member

erich-wang commented Jun 26, 2019

@nithinpnp , it is private repo and you should log in first. BTW, you should have joined Azure organization in github already, right? If not, please checkout https://repos.opensource.microsoft.com/.
Could you reply my first question: "could you share the swagger specs PR link related to this change?"

@nithinpnp
Copy link
Contributor Author

@erich-wang Azure/azure-rest-api-specs#6218
this is the pull request for swagger spec that got approved.

@erich-wang erich-wang merged commit 7f58c79 into Azure:master Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants