Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure-mgmt-compute: VirtualMachineIdentityUserAssignedIdentitiesValue became mangled somewhere between 13.0.0 and 17.0.0 #14150

Closed
jazelenk opened this issue Sep 30, 2020 · 7 comments
Assignees
Labels
Compute issue-addressed Workflow: The Azure SDK team believes it to be addressed and ready to close. Mgmt This issue is related to a management-plane library. Track2

Comments

@jazelenk
Copy link

  • Package Name: azure-mgmt-compute
  • Package Version: 17.0.0
  • Operating System:Linux
  • Python Version: 3.7.3

Describe the bug
azure.mgmt.compute.models.VirtualMachineIdentityUserAssignedIdentitiesValue has changed to azure.mgmt.compute.models.Components1H8M3EpSchemasVirtualmachineidentityPropertiesUserassignedidentitiesAdditionalproperties. Changing names of classes and methods breaks existing code. The nature of the new name suggests this change may be unintentional.

To Reproduce
Steps to reproduce the behavior:

  1. install azure-mgmt-compute
  2. attempt to construct an object with type azure.mgmt.compute.models.VirtualMachineIdentityUserAssignedIdentitiesValue :-)

Expected behavior
This happened to us as a result of a routine upgrade to latest packages. We have been on 13.0.0 for a while, and latest is 17.0.0. We expected the routine upgrade to be seamless.

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 30, 2020
@kaerm kaerm added Compute Mgmt This issue is related to a management-plane library. labels Oct 1, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Oct 1, 2020
@kaerm
Copy link
Contributor

kaerm commented Oct 1, 2020

Thanks @jazelenk for reporting this, @nickzhums could you take a look at this

@nickzhums
Copy link
Contributor

@jazelenk there was a major version upgrade in Python SDK from 13.0.0 to17.0.0. This is actually the reason why there was such a big version jump and an indication for important new changes (and breaking changes)
We actually released a beta version of 17.0.0 a while ago and it has been in preview for several months.

The new version of Python SDK introduces some breaking changes but also important new features such as unified authentication, distributed tracing, and much more. You can find a detailed quickstart and migration guide on this page. link

Do you guys regularly upgrade python ask as a routine?

@changlong-liu changlong-liu self-assigned this Oct 9, 2020
@jazelenk
Copy link
Author

Yes, I understand that the new version contains a lot of breaking changes. This change seems unnecessarily breaking, however, and TBH, it just looks wrong, like autorest blew a gasket or something.

@changlong-liu
Copy link
Member

Hi @jazelenk , We are investigating on this and find this is related to a naming-convention change in codegen. I will have a PR in swagger repo for this so that it can be fixed in next azure-mgmt-compute release.

@xiangyan99
Copy link
Member

@msyyc do you know if this is fixed?

@RAY-316 RAY-316 added the issue-addressed Workflow: The Azure SDK team believes it to be addressed and ready to close. label Dec 15, 2021
@ghost
Copy link

ghost commented Dec 15, 2021

Hi @jazelenk. Thank you for opening this issue and giving us the opportunity to assist. We believe that this has been addressed. If you feel that further discussion is needed, please add a comment with the text “/unresolve” to remove the “issue-addressed” label and continue the conversation.

@ghost
Copy link

ghost commented Dec 22, 2021

Hi @jazelenk, since you haven’t asked that we “/unresolve” the issue, we’ll close this out. If you believe further discussion is needed, please add a comment “/unresolve” to reopen the issue.

@ghost ghost closed this as completed Dec 22, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Compute issue-addressed Workflow: The Azure SDK team believes it to be addressed and ready to close. Mgmt This issue is related to a management-plane library. Track2
Projects
None yet
Development

No branches or pull requests

8 participants