Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Successful restore operations may yield error #18992

Closed
heaths opened this issue May 27, 2021 · 1 comment
Closed

Successful restore operations may yield error #18992

heaths opened this issue May 27, 2021 · 1 comment
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Milestone

Comments

@heaths
Copy link
Member

heaths commented May 27, 2021

Managed HSM may return an "empty" error object in otherwise successful responses, e.g.:

{
  "status": "complete",
  // ...
  "error": {
    "code": null,
    "innererror": null,
    "message": null
  }
}

This may yield an error depending on how the response is processed. To mitigate this possibility, check not only that the error object is null but that the error.code is null before yielding an error.

@heaths heaths added Client This issue points to a problem in the data-plane of the library. KeyVault labels May 27, 2021
@heaths heaths added this to the [2021] June milestone May 27, 2021
@mccoyp mccoyp self-assigned this May 28, 2021
@mccoyp
Copy link
Member

mccoyp commented Jun 16, 2021

Resolved by #19099.

@mccoyp mccoyp closed this as completed Jun 16, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants