Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto merge label not working on the JS repo #2104

Closed
ramya-rao-a opened this issue Oct 14, 2021 · 2 comments
Closed

Auto merge label not working on the JS repo #2104

ramya-rao-a opened this issue Oct 14, 2021 · 2 comments
Labels
needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team.

Comments

@ramya-rao-a
Copy link

See Azure/azure-sdk-for-js#18093

This PR has the auto merge label, has been approved, CI is green. It should have gotten automatically merged, but it has not

cc @praveenkuttappan
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Oct 14, 2021
@weshaggard
Copy link
Member

I don't know if it was the case then but currently there is a merge conflict which blocks the merging.

That said I will say the auto-merge label is handled by the fabric bot and I've definitely see it lose track of a given PR, usually some webhook notification that gets lost somewhere.

@ramya-rao-a
Copy link
Author

Ok, my bad

I had seen auto merge not working a few days ago, thought the problem still persisted

I see other PRs have been auto merged properly, see Azure/azure-sdk-for-js#18110

Will close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@weshaggard @ramya-rao-a