[Prioritized] Normalize line endings

[pakrym]

@JoshLove-msft @scbedd

[scbedd]

Doing some digging into this. Found this issue which is basically exactly our scenario.

So I think we need to create a custom Utf8JsonWriter and override the WriteIndent call to insider \n instead of Environment.NewLine.

We should also update our we load the recording to ignore crlf when deserializing from the recording file.

[JoshLove-msft]

Doing some digging into this. Found this issue which is basically exactly our scenario.

So I think we need to create a custom Utf8JsonWriter and override the WriteIndent call to insider \n instead of Environment.NewLine.

We should also update our we load the recording to ignore crlf when deserializing from the recording file.

I think the issue is with the actual content, not the formatted JSON. When matching we renormalize the JSON anyways so it should handle this for us. But the issue happens when someone adds line breaks based on Environment.NewLine from their own test into the request content. The workaround is to either hard-code the new line value or just remove them.

[scbedd]

When matching we renormalize the JSON anyways so it should handle this for us.

Yeah I'm seeing this now.

But the issue happens when someone adds line breaks based on Environment.NewLine from their own test into the request content

Hmmm. So add a hardcoded replace on \r\n if the request content is a text content type? That's honestly the only way I see to resolve this, as the content is actually in the recorded request. It's not added to the recording when outputting the recording to disk.

when someone adds line breaks based on Environment.NewLine from their own test into the request content

I can see how this might be the proxy's place to do this, but I'm super leery towards it. Bright side is that this is not a breaking change. Existing recordings would just have crlf content silently replaced when matching.

[JoshLove-msft]

Agreed that this shouldn't be a breaking change. I think essentially normalizing the line breaks when matching is the way to go.