Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PR Workflow] ARMReview label was not added in spite of the relevant checkbox being checked #6219

Closed
konrad-jamrozik opened this issue May 23, 2023 · 2 comments
Closed

[PR Workflow] ARMReview label was not added in spite of the relevant checkbox being checked #6219

konrad-jamrozik opened this issue May 23, 2023 · 2 comments
Assignees
@konrad-jamrozik
Labels
Central-EngSys This issue is owned by the Engineering System team. Spec PR Tools Tooling that runs in azure-rest-api-specs repo.

Comments

@konrad-jamrozik
Copy link
Contributor

konrad-jamrozik commented May 23, 2023 •
edited
Loading

In this PR:

Discussion here.

PR pipeline runs:
@github-actions github-actions bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label May 23, 2023
@konrad-jamrozik konrad-jamrozik added Central-EngSys This issue is owned by the Engineering System team. Spec PR Tools Tooling that runs in azure-rest-api-specs repo. labels May 23, 2023
@konrad-jamrozik konrad-jamrozik removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label May 23, 2023
@konrad-jamrozik konrad-jamrozik self-assigned this May 23, 2023
@konrad-jamrozik konrad-jamrozik moved this from 🤔 Triage to 📋 Backlog in Azure SDK EngSys 🤖🧠 May 24, 2023
@konrad-jamrozik konrad-jamrozik moved this to 🐝 In Progress in Spec PR Tools May 24, 2023
@konrad-jamrozik konrad-jamrozik moved this from 🐝 In Progress to 📋 Backlog in Spec PR Tools May 24, 2023
@konrad-jamrozik
Copy link
Contributor Author

konrad-jamrozik commented May 24, 2023 •
edited
Loading

The first run of the PR shows it skipped adding the label because it is a draft, per this log. I spot checked other runs and it appears to be always the case, including the most recent run.

Here is another issue discussing the issue with draft PRs not getting this label:

@konrad-jamrozik konrad-jamrozik mentioned this issue May 24, 2023
Closed
@konrad-jamrozik
Copy link
Contributor Author

The checkbox is no longer there.

@konrad-jamrozik konrad-jamrozik closed this as not planned Won't fix, can't repro, duplicate, stale May 6, 2024
@github-project-automation github-project-automation bot moved this from 📋 Backlog to 🎊 Closed in Spec PR Tools May 6, 2024
@github-project-automation github-project-automation bot moved this from 📋 Backlog to 🎊 Closed in Azure SDK EngSys 🤖🧠 May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@konrad-jamrozik konrad-jamrozik

Labels
Central-EngSys This issue is owned by the Engineering System team. Spec PR Tools Tooling that runs in azure-rest-api-specs repo.
Projects
Azure SDK EngSys 🤖🧠
Archived in project
Spec PR Tools
Status: 🎊 Closed
Milestone
No milestone
Development

No branches or pull requests
1 participant
@konrad-jamrozik