Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tsp-client] The output of the tsp compile command should be logged using the Logger #8523

Closed
raych1 opened this issue Jul 1, 2024 · 4 comments · Fixed by #8529
Closed
Assignees
Labels
TypeSpec Issues or feature requests for tooling to support TypeSpec (Cadl)

Comments

@raych1
Copy link
Member

raych1 commented Jul 1, 2024

Description
The output while calling the SDK emitter in tsp-client is currently only displayed in the console. For better troubleshooting, this output should also be emitted to the Logger so that it can be displayed in the pipeline scenario.

This is the code location:

//CC: @catalinaperalta @chunyu3

@raych1 raych1 added the TypeSpec Issues or feature requests for tooling to support TypeSpec (Cadl) label Jul 1, 2024
@chunyu3
Copy link
Member

chunyu3 commented Jul 2, 2024

Hello @catalinaperalta in .NET generator we will log some information, but when tsp-client execute .Net emitter, the logs of .NET emitter are missing.

When I run local, it can see the logs, but when run in ci pipeline, the logs are missing

@catalinaperalta
Copy link
Member

catalinaperalta commented Jul 2, 2024

Hi all, I opened a PR addressing this yesterday, waiting on a review then will release a tsp-client update. Feel free to add your own review on the PR as well :)

@catalinaperalta
Copy link
Member

catalinaperalta commented Jul 3, 2024

v0.9.1 of tsp-client was released and is now printing the diagnostics with the logger. Please update to that version and give it a try. Thanks

@catalinaperalta
Copy link
Member

catalinaperalta commented Jul 27, 2024

@raych1 the output of the diagnostics causes a lot of noise when generating using tsp-client. Any issues if I log them at the debug level? I think you're already using the --debug flag in the pipeline, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TypeSpec Issues or feature requests for tooling to support TypeSpec (Cadl)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants